-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Python3.11 #1246
Support Python3.11 #1246
Conversation
875a9f1
to
89b1ced
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing reuse_addr for UDP is a good thing, I thought I had done that already. BUT you cannot remove reuse_addr from TCP, this is highly needed.
IMPORTANT, please do a "git pull" before making changes, I added a commit changing README.rst |
You had set it to
OK, I assume TLS follows TCP. Changed to only UDP.
OK. I rebased and force-pushed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I wrote earlier "IMPORTANT, please do a "git pull" before making changes, I added a commit changing README.rst"
You did not do that, but instead did "git push -f" and thus killed my commit. It would have been nice, it you had included the change in your commit, so I avoided doing it twice.
My apologies for not understanding your message, although I didn't ignore it. I saw you had committed 33659da, which merged I pulled Had you encountered a merge conflict? Did I make a mistake in the rebase? |
I did a commit on this branch not dev. I did it directly on dev in the second turn. I did not encounter a merge conflict my commit was simply gone, due to your “git push —force…” (any version of —force, replaces the commit log for the branch on the server with your version). You should have done “git pull” before starting to work, then the normal “git push” would have worked. But anyhow it is history now and it was not a big problem, just wanted to mention it. Looking forward to see more work from you. Let me know if you want ideas of what needs to be done. |
* Remove deprecated allow_reuse_address from UDP * Add Python3.11 to CI
Closes #1245.
All tests pass on Python3.11 the same as Python3.10 and 3.8 on MacOS for me.
I see you have simplified and cleaned up the CI a lot; awesome! Hopefully it's easy to add 3.11