Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python3.11 #1246

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Support Python3.11 #1246

merged 2 commits into from
Jan 10, 2023

Conversation

alexrudd2
Copy link
Collaborator

Closes #1245.

All tests pass on Python3.11 the same as Python3.10 and 3.8 on MacOS for me.

I see you have simplified and cleaned up the CI a lot; awesome! Hopefully it's easy to add 3.11

@alexrudd2 alexrudd2 force-pushed the python3.11 branch 2 times, most recently from 875a9f1 to 89b1ced Compare January 9, 2023 23:17
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing reuse_addr for UDP is a good thing, I thought I had done that already. BUT you cannot remove reuse_addr from TCP, this is highly needed.

examples/contrib/serial_forwarder.py Outdated Show resolved Hide resolved
examples/server_async.py Outdated Show resolved Hide resolved
examples/server_async.py Show resolved Hide resolved
examples/server_async.py Outdated Show resolved Hide resolved
@janiversen
Copy link
Collaborator

IMPORTANT, please do a "git pull" before making changes, I added a commit changing README.rst

@alexrudd2
Copy link
Collaborator Author

alexrudd2 commented Jan 10, 2023

Removing reuse_addr for UDP is a good thing, I thought I had done that already.

You had set it to False, which emitted a DeprecationWarning previously and is now entirely removed in 3.11

BUT you cannot remove reuse_addr from TCP, this is highly needed.

OK, I assume TLS follows TCP. Changed to only UDP.

IMPORTANT, please do a "git pull" before making changes, I added a commit changing README.rst

OK. I rebased and force-pushed.

@alexrudd2 alexrudd2 requested a review from janiversen January 10, 2023 17:59
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I wrote earlier "IMPORTANT, please do a "git pull" before making changes, I added a commit changing README.rst"

You did not do that, but instead did "git push -f" and thus killed my commit. It would have been nice, it you had included the change in your commit, so I avoided doing it twice.

@janiversen janiversen merged commit e17557f into pymodbus-dev:dev Jan 10, 2023
@alexrudd2
Copy link
Collaborator Author

My apologies for not understanding your message, although I didn't ignore it.

I saw you had committed 33659da, which merged dev into my branch. (It's still available with git log) I did not see any relevant README changes that weren't in other commits - the changes present would get dropped by merging this back into dev.

I pulled dev and rebased this branch on top so there were no conflicts, then did git push --force-with-lease. Using this instead of --force means I had was not overwriting any remote commits I had not seen.

Had you encountered a merge conflict? Did I make a mistake in the rebase?

@alexrudd2 alexrudd2 deleted the python3.11 branch January 11, 2023 00:37
@janiversen
Copy link
Collaborator

I did a commit on this branch not dev. I did it directly on dev in the second turn.

I did not encounter a merge conflict my commit was simply gone, due to your “git push —force…” (any version of —force, replaces the commit log for the branch on the server with your version).

You should have done “git pull” before starting to work, then the normal “git push” would have worked. But anyhow it is history now and it was not a big problem, just wanted to mention it.

Looking forward to see more work from you. Let me know if you want ideas of what needs to be done.

alexrudd2 added a commit to alexrudd2/pymodbus that referenced this pull request Feb 21, 2023
* Remove deprecated allow_reuse_address from UDP

* Add Python3.11 to CI
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.11 deprecation: reuse_address in loop.create_datagram_endpoint
2 participants