Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in comments #1233

Merged
merged 3 commits into from
Jan 2, 2023
Merged

Fix typos in comments #1233

merged 3 commits into from
Jan 2, 2023

Conversation

matthiasstraka
Copy link
Contributor

Fixed several typos in source file comments

janiversen
janiversen approved these changes Dec 21, 2022
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@janiversen
Copy link
Collaborator

Let me know once it is ready for review, looks good so far.

@janiversen janiversen self-requested a review December 21, 2022 17:03
@matthiasstraka matthiasstraka marked this pull request as ready for review December 22, 2022 08:19
@janiversen janiversen added this to the Version 3.2 milestone Dec 23, 2022
janiversen
janiversen approved these changes Jan 2, 2023
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

Merging it, to avoid further conflicts. If you find more (or want to enhance some of the descriptions) please submit a new PR.

@janiversen janiversen merged commit 6224f71 into pymodbus-dev:dev Jan 2, 2023
@matthiasstraka
Copy link
Contributor Author

Thanks, currently I have not planned similar prs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janiversen janiversen janiversen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthiasstraka @janiversen