Advanced simulator with cross memory. #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janiversen
force-pushed
the
simulator_advanced
branch
16 times, most recently
from
e12539e to
e5b4834
Compare
janiversen
force-pushed
the
simulator_advanced
branch
2 times, most recently
from
bf10467 to
3918ecb
Compare
janiversen
force-pushed
the
simulator_advanced
branch
from
88de88f to
2f15816
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the simulator to have a central memory model and the 4 blocks (coils etc) as offsets.
This model allows sharing of memory e.g. reading an address with both read_coils() and read_register().
Further updated a bit on the exception handling.
Remove json file load, that is really not an integral part of the datastore, apart from that the datastore+simulator might want a more complete json file (e.g. with ident).