Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serial receive incomplete bytes.issue#1183 #1185

Merged
merged 2 commits into from
Nov 11, 2022

Conversation

banana-sun
Copy link
Contributor

@banana-sun banana-sun commented Nov 11, 2022

In function recv of pymodbus/client/serial.py, when size if not None, serial does not wait data.

fixes #1183

Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the change breaks most of the tests.

@janiversen janiversen force-pushed the fix/incomplete_receive_bytes branch from 2012bb5 to d305966 Compare November 11, 2022 15:21
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added commit to solve problems.

@janiversen janiversen force-pushed the fix/incomplete_receive_bytes branch from d305966 to 8f0789c Compare November 11, 2022 15:31
@janiversen janiversen merged commit 94044f1 into pymodbus-dev:dev Nov 11, 2022
@banana-sun banana-sun deleted the fix/incomplete_receive_bytes branch November 11, 2022 16:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function code 0x15 fails because of incomplete receival of bytes
2 participants