Bugfix ModbusSerialServer setup so handler is called correctly. #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually there are tests for ModbusSerialServer in test_examples.py |
|
Thanks for the patch, looking forward to see more work from you. |
Ah, I see it now. run_async_server can take "serial" and use StartAsyncSerialServer then. Sorry. I was looking at test_server_asyncio.py which does the others but not StartAsyncSerialServer. |
|
you also have run_sync_server, so we should have it all covered. Apart from that your patch was correct and are merged, thanks again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was hit by ModbusSerialServer being broken by the previous commit to async_io.py.
There is no test covering ModbusSerialServer which is probably why this got through. One could be added using pty.openpty.