Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit to arguments #1041

Merged
merged 3 commits into from
Aug 17, 2022
Merged

Add unit to arguments #1041

merged 3 commits into from
Aug 17, 2022

Conversation

pkubanek
Copy link
Contributor

Fix #673. Adds unit to argument list for selected functions.

@pkubanek pkubanek mentioned this pull request Aug 17, 2022
Closed
janiversen
janiversen requested changes Aug 17, 2022
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems you changed mind, about halfway through the modifications and started to use another description, please correct the first half to the latter.

pymodbus/repl/client/mclient.py Show resolved Hide resolved
@pkubanek pkubanek force-pushed the dev branch 2 times, most recently from 9b9c005 to 6fb7783 Compare August 17, 2022 10:20
@janiversen
Copy link
Collaborator

Der er et pylint problem

pymodbus/repl/client/mclient.py:99:43: W0613: Unused argument 'unit' (unused-argument)
[595](https://github.com/riptideio/pymodbus/runs/7876551304?check_suite_focus=true#step:5:596)
pymodbus/repl/client/mclient.py:300:18: E1121: Too many positional arguments for constructor call (too-many-function-args)
[596](https://github.com/riptideio/pymodbus/runs/7876551304?check_suite_focus=true#step:5:597)
************* Module pymodbus.client.mixin
[597](https://github.com/riptideio/pymodbus/runs/7876551304?check_suite_focus=true#step:5:598)
pymodbus/client/mixin.py:160:55: W0613: Unused argument 'unit' (unused-argument)

@pkubanek pkubanek requested a review from janiversen August 17, 2022 12:50
janiversen
janiversen requested changes Aug 17, 2022
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update.

pymodbus/pdu.py Outdated Show resolved Hide resolved
pymodbus/pdu.py Outdated Show resolved Hide resolved
pymodbus/register_read_message.py Outdated Show resolved Hide resolved
pymodbus/register_read_message.py Outdated Show resolved Hide resolved
pymodbus/register_read_message.py Outdated Show resolved Hide resolved
pymodbus/register_read_message.py Outdated Show resolved Hide resolved
@janiversen
Copy link
Collaborator

I wonder what you broke, but I will take a closer look.

@pkubanek pkubanek requested a review from janiversen August 17, 2022 13:35
@pkubanek
Copy link
Contributor Author

Added commit to use super() in files I modified.

janiversen
janiversen approved these changes Aug 17, 2022
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think CI do not like it, could be you are not on the newest dev.

janiversen
janiversen requested changes Aug 17, 2022
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flake8

pymodbus/pdu.py Show resolved Hide resolved
@swamper123
Copy link
Collaborator

Ci says pymodbus/pdu.py:146:5: E303 too many blank lines (2)

@janiversen
Copy link
Collaborator

yes already solved.

@janiversen janiversen merged commit 34acafd into pymodbus-dev:dev Aug 17, 2022
@janiversen
Copy link
Collaborator

Thanks for the PR, hope you will want to continue.

@pkubanek pkubanek mentioned this pull request Aug 18, 2022
Closed
pkubanek added a commit to pkubanek/pymodbus that referenced this pull request Aug 18, 2022
@pkubanek
Fixed issues createed by PR pymodbus-dev#1041
314a4ae
pkubanek added a commit to pkubanek/pymodbus that referenced this pull request Sep 1, 2022
@pkubanek
Fixed issues created by PR pymodbus-dev#1041
40e66e7
@ohshazbot ohshazbot mentioned this pull request Mar 16, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janiversen janiversen janiversen requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unit parameter
3 participants
@pkubanek @janiversen @swamper123