Type Hint for write_registers value parameter wrong?

[rauberdaniel]

BinaryPayloadBuilder.build(…) returns list[bytes]

def build(self) -> list[bytes]:

but ModbusTcpClient.write_registers(…) expects list[int] as values argument

def write_registers(self, address: int, values: list[int], slave: int = 1, skip_encode: bool = False) -> T:

According to my tests, write_registers however actually expects list[bytes] so I think this type hint there is wrong? Can anybody confirm or deny that?

[janiversen]

I will take a look.

[janiversen]

You are right it should be list[bytes], while write_register expects an int.

You are welcome to make a pull request if you want, otherwise I will correct it when I get around to it,
.