Server and client decoders handle exceptions differently

[alexrudd2]

ServerDecoder

pymodbus/pymodbus/factory.py

Lines 92 to 102 in 1b2cb7e

	def decode(self, message):
	"""Decode a request packet.
	:param message: The raw modbus request packet
	:return: The decoded modbus message or None if error
	"""
	try:
	return self._helper(message)
	except ModbusException as exc:
	Log.warning("Unable to decode request {}", exc)
	return None

ClientDecoder

pymodbus/pymodbus/factory.py

Lines 229 to 241 in 1b2cb7e

	def decode(self, message):
	"""Decode a response packet.
	:param message: The raw packet to decode
	:return: The decoded modbus message or None if error
	"""
	try:
	return self._helper(message)
	except ModbusException as exc:
	Log.error("Unable to decode response {}", exc)
	except Exception as exc: # pylint: disable=broad-except
	Log.error("General exception: {}", exc)
	return None

The generic except Exception was added a long time ago in 1.5.0

It doesn't seem right to have them differ; which is preferred?

[janiversen]

you are right, the first one is better (without the generic exception).