Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching a synced mailing list only shows contacts that are users #463

Closed
CustomCodeIT opened this issue Mar 26, 2024 · 7 comments
Closed
Labels
bug Something isn't working

Comments

@CustomCodeIT
Copy link

CustomCodeIT commented Mar 26, 2024

Please provide a clear and concise description of what the bug is, including:

Reproduce

  • Create a user group and add some users
  • Use the Campaign sync feature to sync users from that group into a mailing list
  • Manually add a contact to the mailing list
  • Search for the manually added contact and note no search results.
  • Interestingly, even after adding a manually created contact as a user, searching them still doesn't show results.

Expectation

I expect to be able to search all contacts in a mailing list, whether they were synced from a user group or manually added.

Screenshots

image image image

Version Info

Craft Pro 4.8.5
Campaign Pro 2.13.0

Other Notes

Tested on both an existing Craft site and a brand new fresh install.

@CustomCodeIT CustomCodeIT added the bug Something isn't working label Mar 26, 2024
@bencroker
Copy link
Collaborator

I just tested manually adding a user locally. It was synced to a new contact and searching for the email address works just as expected.

Does searching under “All contacts” work? Can you try it again with a new user, checking for any relevant errors in the logs?

@CustomCodeIT
Copy link
Author

CustomCodeIT commented Mar 26, 2024

That's correct and aligns with what I'm seeing. If you create a Craft user, everything works as expected. However, if you manually add a contact to a mailing list with sync enabled, that contact doesn't show in search results. Even if you create a Craft user matching that user email after the fact.

Searching under "All contacts" yields the same result. Logs all look clean with no errors or anything out of the norm

Edit: Updated my terminology in the original report as I said "user" where I should have said "contact"

@CustomCodeIT
Copy link
Author

If it helps demonstrate what I'm seeing:

https://www.youtube.com/watch?v=Ei6XZnUYK0w

@bencroker
Copy link
Collaborator

bencroker commented Mar 26, 2024

Now that you clarified the issue is with creating a contact, I can replicate. It doesn’t look like the synced list plays any role in the issue, however. I’ll investigate and let you know what I find.

@CustomCodeIT
Copy link
Author

Yeah that's my bad, glad you're able to replicate it now though. Thanks for looking into it.

@bencroker
Copy link
Collaborator

Fixed in 382062c for the next release.

@bencroker
Copy link
Collaborator

Released in 2.13.1 and 3.0.0-beta.2. Thanks for reporting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants