Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BoundedEnum instance for Int has invalid cardinality #25

Closed
matthewleon opened this issue Mar 5, 2017 · 2 comments
Closed

BoundedEnum instance for Int has invalid cardinality #25

matthewleon opened this issue Mar 5, 2017 · 2 comments

Comments

@matthewleon
Copy link
Contributor

matthewleon commented Mar 5, 2017 •
edited
Loading

Yes, Int violates a lot of typeclass laws... But the BoundedEnum instance having a cardinality of -1 seems particularly egregious. It certainly trapped me. Is this instance worth keeping despite that?
@garyb
Copy link
Member

garyb commented Mar 26, 2017

@paf31 what do you think we should do here? I guess we should use a Nat for cardinality really...

We could drop the instance, or use Number instead of Int perhaps? 😕

@paf31
Copy link
Contributor

paf31 commented Mar 26, 2017

I think we should just remove it for now.

@garyb garyb mentioned this issue Mar 26, 2017
Merged
@garyb garyb closed this as completed in #26 Mar 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@matthewleon @paf31 @garyb