-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support chrome headless mode #8260
Merged
Merged
+45
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
chrome-headless
branch
3 times, most recently
from
April 22, 2022 10:43
4d27a16
to
3438a55
Compare
ergunsh
approved these changes
Apr 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with comments
Co-authored-by: Ergün Erdoğmuş <[email protected]>
Co-authored-by: Ergün Erdoğmuş <[email protected]>
kzar
added a commit
to kzar/duckduckgo-privacy-extension
that referenced
this pull request
May 7, 2022
Puppeteer recently added headless support for running Chrome extensions[1], so let's make use of that. Also, let's take care to properly wait for the extension's background page to load. 1 - puppeteer/puppeteer#8260
12 tasks
kzar
added a commit
to kzar/duckduckgo-privacy-extension
that referenced
this pull request
May 9, 2022
Puppeteer recently added headless support for running Chrome extensions[1], so let's make use of that. Also, let's take care to properly wait for the extension's background page to load. 1 - puppeteer/puppeteer#8260
kzar
added a commit
to kzar/duckduckgo-privacy-extension
that referenced
this pull request
May 11, 2022
Puppeteer recently added headless support for running Chrome extensions[1], so let's make use of that. Also, let's take care to properly wait for the extension's background page to load. 1 - puppeteer/puppeteer#8260
jonathanKingston
pushed a commit
to duckduckgo/duckduckgo-privacy-extension
that referenced
this pull request
May 12, 2022
Puppeteer recently added headless support for running Chrome extensions[1], so let's make use of that. Also, let's take care to properly wait for the extension's background page to load. 1 - puppeteer/puppeteer#8260
This was referenced May 30, 2022
This was referenced May 30, 2022
This was referenced May 30, 2022
This was referenced Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues: #8173