Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve HTTPS validation #1701

Open
ghost opened this issue May 31, 2019 · 0 comments
Open

improve HTTPS validation #1701

ghost opened this issue May 31, 2019 · 0 comments

Comments

@ghost
Copy link

ghost commented May 31, 2019

If you are running pump.io behind a reverse proxy, you really don't need to set up the SSL key/cert because you can set up directly for example in NGINX, so we should improve that validation or add and options like useHTTPS or check if the port is 443, because if the server run with 443 without ssl cert it still send the request over http and will get invalid signature error.

https://github.com/pump-io/pump.io/blob/master/lib/app.js#L201

Related: #1699

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants