Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment Settings's OIDC has noisy diff on READ #330

Closed
IaroslavTitov opened this issue Jun 24, 2024 · 1 comment
Closed

Deployment Settings's OIDC has noisy diff on READ #330

IaroslavTitov opened this issue Jun 24, 2024 · 1 comment
Assignees
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Milestone

Comments

@IaroslavTitov
Copy link
Contributor

IaroslavTitov commented Jun 24, 2024

What happened?

Deployment Settings's OIDC has noisy diff on READ. Please investigate and fix the issue.

Example

Tested on TS:

        oidc: {
            aws: {
                roleARN: "arn:aws:iam::123456789012:role/MyRole",
                duration: "1h",
                sessionName: "my-session",
            },
            gcp: {
                projectId: "my-project",
                region: "us-west1",
                workloadPoolId: "my-workload-pool",
                providerId: "my-provider",
                serviceAccount: "my-service-account",
                tokenLifetime: "30s",
            },
            azure: {
                tenantId: "my-tenant-id",
                clientId: "my-client-id",
                subscriptionId: "my-subscription-id",
            }
        }

shows diff of

      ~ operationContext: {
          ~ oidc: {
              ~ aws  : {
                  ~ duration: "1h0m0s" => "1h0m0s"
                }
              - azure: <null>
            }
        }

Output of pulumi about

Not relevant

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@IaroslavTitov IaroslavTitov added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team and removed needs-triage Needs attention from the triage team labels Jun 24, 2024
@cleverguy25 cleverguy25 added this to the 0.107 milestone Jun 26, 2024
@IaroslavTitov IaroslavTitov added the resolution/fixed This issue was fixed label Jul 10, 2024
@IaroslavTitov
Copy link
Contributor Author

Fixed in #348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Development

No branches or pull requests

2 participants