Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSA patchForce option as provider config #2280

Open
lblackstone opened this issue Jan 3, 2023 · 1 comment
Open

Add SSA patchForce option as provider config #2280

lblackstone opened this issue Jan 3, 2023 · 1 comment
Labels
area/server-side-apply kind/enhancement Improvements or new features

Comments

@lblackstone
Copy link
Member

lblackstone commented Jan 3, 2023

The Server-side Apply patchForce option is currently settable using an annotation per-resource, or with an environment variable. It may also be useful to expose as a provider config option so that it can be set on a per-stack basis.

Hmm... good question. I've had situations where I had a lot of conflicts and it was tedious to add the annotation per resource, in those cases I thought to myself that a config option would be really useful. That way I know just from looking at the stack config that we're set to force patch on conflict without relying on an env var that might be not be set (depending on the machine running pulumi up)

I guess it's a matter of preference, I prefer explicitly setting things in the stack config instead of relaying implicitly on the running environment. That way the entire project is self contained without any external arguments.

Originally posted by @hagaibarel in #2259 (comment)

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@EronWright
Copy link
Contributor

I would also advocate for a provider config option, since it can be difficult to set an environment variable in some CI environments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/server-side-apply kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants