-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporate CRDs into Python codebase #66
Comments
@benglewis could you give me an example of the code you're generating, and how that differs from the published Python types? Also, are you referring to this example or something else? I'm unsure what you mean by unchecked, what would you expect it to look like instead?
Help is always welcome and appreciated! |
@blampe https://github.com/benglewis/pulumi-kubernetes-cert-manager |
A little more context, essentially all I did was run https://github.com/pulumi/crd2pulumi on the CRDs YAML that |
@benglewis thank you for putting this together! Some thoughts/questions:
|
I saw that you tagged @EronWright in my PR for review. If you can confirm that if I replace the manually run of |
@benglewis Conceptually, this is a great idea; we'd love to have typed APIs for lots of charts in the registry. However, I don't think we can take take exactly the approach from your PR. There's some practical concerns like the ones @blampe mentioned above, but we're also currently making an investment in an overhaul of crd2pulumi that should fix lots of the current SDK generation issues so that using that tool directly in your projects will become much more practical. I also recognize that even if crd2pulumi is perfect, it would still be nice to get those SDKs into our registry somehow so they can have documentation, be published in to PyPi and other language package managers, etc. We have some ideas for how to do that in a way that can scale to many CRDs. In the meantime, we can keep this ticket open to track the need (and collect upvotes here). |
I do love the idea of providing strongly-typed wrappers for the CRDs of cert-manager, whether generated by crd2pulumi or by another tool. Obviously the wrappers should work seamlessly with this |
Can we widen this issue to include other languages not just Python? It's a particular shame the typescript SDK does not include these given that: a) |
Hello!
Issue details
Use
crd2pulumi
with slight adjustments to create Pulumi Python library code for Custom Resource Definitions. As of now, I am doing this in my own codebase to do the nice type-checking and write Python code rather than the unchecked CRD shown in the example, but it would be nice to have it be official. I can contribute my changes to the output fromcrd2pulumi
if it would help.Affected area/feature
Pulumi integration with
cert-manager
CRDsThe text was updated successfully, but these errors were encountered: