Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Warning to write to persistent logs #464

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Set Warning to write to persistent logs #464

merged 1 commit into from
Jan 20, 2023

Conversation

guineveresaenger
Copy link
Contributor

Warnings should persist after running pulumi up.

Fixes #463.

@guineveresaenger guineveresaenger requested review from iwahbe and a team January 20, 2023 19:19
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

aq17
aq17 approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@aq17 aq17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guineveresaenger guineveresaenger merged commit 4dca334 into master Jan 20, 2023
@guineveresaenger guineveresaenger deleted the persistent-logs branch January 20, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aq17 aq17 aq17 approved these changes

@iwahbe iwahbe Awaiting requested review from iwahbe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cleanup] Use non-transient logs for warnings
2 participants
@guineveresaenger @aq17