Fix panic in Check function #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `build` field is unset entirely, the Check function was panicking attempting to set the implicit `contextDigest` field. This PR properly constructs the `inputs["build"]` field as a `resource.NewObjectProperty`.
AaronFriel
reviewed
Jan 20, 2023
provider/provider.go
Outdated
| @@ -125,7 +125,10 @@ func (p *dockerNativeProvider) Check(ctx context.Context, req *rpc.CheckRequest) | |||
| } | |||
|
|
|||
| // add implicit resource to provider | |||
| inputs["build"].ObjectValue()["contextDigest"] = resource.NewStringProperty(contextDigest) | |||
| inputs["build"] = resource.NewObjectProperty(resource.PropertyMap{ | |||
There was a problem hiding this comment.
This would replace inputs["build"] if the user set it - are we overriding anything the user would input?
There was a problem hiding this comment.
d'oh!
Added a null check condition.
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
AaronFriel
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
buildfield is unset entirely, the Check function waspanicking attempting to set the implicit
contextDigestfield.This PR properly constructs the
inputs["build"]field as aresource.NewObjectProperty.