Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Dockerhub behavior #466

Closed
guineveresaenger opened this issue Jan 24, 2023 · 0 comments · Fixed by #465
Closed

Default Dockerhub behavior #466

guineveresaenger opened this issue Jan 24, 2023 · 0 comments · Fixed by #465
Assignees
Labels
4.x.x kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Milestone

Comments

@guineveresaenger
Copy link
Contributor

guineveresaenger commented Jan 24, 2023

The Docker CLI treats Dockerhub as a special case, allowing local/short names for images such as username/imagename:tag to be implicitly tagged as docker.io/username/imagename:tag when attempting a docker push. As long as the user is logged in to Dockerhub, this image will be pushed.

In the context of a Pulumi program, emulating this behavior this could result in accidentally pushing an image to Dockerhub, and it would make sense from a security perspective to disallow this default behavior.

Now that it is possible to use host auth config implicitly, we need to decide what the behavior should be instead.

The most straightforward behavior would be to require setting Dockerhub explicitly:

  • via a fully qualified image name: docker.io/username/imagename:tag
  • or via setting the registry server field explicitly to use Dockerhub: docker.io OR index.docker.io/v1
@guineveresaenger guineveresaenger self-assigned this Jan 24, 2023
@guineveresaenger guineveresaenger added the kind/enhancement Improvements or new features label Jan 25, 2023
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Jan 27, 2023
@AaronFriel AaronFriel added this to the 0.84 milestone Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x.x kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants