Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider authentication from Docker config #442

Closed
2 tasks done
guineveresaenger opened this issue Dec 9, 2022 · 1 comment · Fixed by #461
Closed
2 tasks done

Provider authentication from Docker config #442

guineveresaenger opened this issue Dec 9, 2022 · 1 comment · Fixed by #461
Assignees
Labels
4.x.x kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Milestone

Comments

@guineveresaenger
Copy link
Contributor

guineveresaenger commented Dec 9, 2022

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

We cannot use simple password auth on Image Registry in all use cases.

Affected area/feature

Related: #51

@guineveresaenger guineveresaenger added kind/enhancement Improvements or new features 4.x.x labels Dec 9, 2022
@AaronFriel
Copy link
Contributor

The skaffold implementation here may be usable - as a library or we could reimplement if we need to handle non-canonical references. https://github.com/GoogleContainerTools/skaffold/blob/main/pkg/skaffold/docker/auth.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x.x kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants