Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image: Deprecate OneOf implementation for build #428

Closed
guineveresaenger opened this issue Nov 28, 2022 · 1 comment · Fixed by #518
Closed

Image: Deprecate OneOf implementation for build #428

guineveresaenger opened this issue Nov 28, 2022 · 1 comment · Fixed by #518
Assignees
@guineveresaenger
Labels
4.x.x kind/task Work that's part of an ongoing epic resolution/fixed This issue was fixed
Milestone
0.85

Comments

@guineveresaenger
Copy link
Contributor

In v3.x.x, we allow for build to be a string or an instance ofDockerBuildArgs.

This string type allows the user to set a folder path for the Docker build context, in case the Dockerfile is not located in the current folder.

However, DockerBuildArgs contains a field called context, which provides the exact same functionality. We should remove the OneOf option and migrate users to use DockerBuildArgs -> context -> .
@guineveresaenger guineveresaenger mentioned this issue Dec 6, 2022
Closed
@guineveresaenger guineveresaenger mentioned this issue Feb 8, 2023
Merged
This was referenced Mar 7, 2023
Closed
Merged
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Mar 7, 2023
@pulumi-bot pulumi-bot reopened this Mar 7, 2023
@pulumi-bot
Copy link
Contributor

Cannot close issue without required labels: kind/

@guineveresaenger guineveresaenger self-assigned this Mar 7, 2023
@guineveresaenger guineveresaenger added the kind/task Work that's part of an ongoing epic label Mar 7, 2023
@mikhailshilkov mikhailshilkov added this to the 0.85 milestone Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guineveresaenger guineveresaenger

Labels
4.x.x kind/task Work that's part of an ongoing epic resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.85
3 participants
@mikhailshilkov @guineveresaenger @pulumi-bot