Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example for container is missing code blocks #1201

Open
andrzejressel opened this issue Aug 20, 2024 · 2 comments
Open

Example for container is missing code blocks #1201

andrzejressel opened this issue Aug 20, 2024 · 2 comments
Labels
area/docs Improvements or additions to documentation kind/bug Some behavior is incorrect or out of spec

Comments

@andrzejressel
Copy link

andrzejressel commented Aug 20, 2024

Describe what happened

Example for container resource looks weird, because it's missing code blocks (for #!/bin/bash and terraform part): https://www.pulumi.com/registry/packages/docker/api-docs/container/#example

Terraform registry is rendering it just fine https://registry.terraform.io/providers/kreuzwerker/docker/latest/docs/resources/container#import

Sample program

N/A

Log output

N/A

Affected Resource(s)

container

Output of pulumi about

N/A

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@andrzejressel andrzejressel added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Aug 20, 2024
@blampe blampe added area/docs Improvements or additions to documentation and removed needs-triage Needs attention from the triage team labels Aug 23, 2024
@andrzejressel
Copy link
Author

This is weird - I've copied tf markdown to pulumi-terraform-bridge so I can run tests on it and it seems to be converting fine. But it is still broken in generation: https://github.com/pulumi/pulumi-docker/blob/master/sdk/java/src/main/java/com/pulumi/docker/Container.java#L97

@andrzejressel
Copy link
Author

andrzejressel commented Sep 1, 2024

I believe it's due to the very strict rules regarding import parsing. Now i see 2 issues:

  1. !#/bin/bash is spilling outside of code block
  2. Non shell code blocks are ignored

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Improvements or additions to documentation kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Development

No branches or pull requests

2 participants