Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unconventional Naming for BucketObjectv2 in Pulumi AWS Java SDK #4843

Open
rodolfoagomes1987 opened this issue Nov 26, 2024 · 2 comments
Open
Labels
impact/breaking Fixing this issue will require a breaking change kind/bug Some behavior is incorrect or out of spec

Comments

@rodolfoagomes1987
Copy link

I noticed that the class BucketObjectv2 in the Pulumi AWS Java SDK does not follow standard Java naming conventions (PascalCase). Typically, Java classes use names like BucketObjectV2. Is this an intentional design decision? If not, would it be possible to rename it to align with Java conventions in future versions?

SDK Version: 6.61.0
Package: com.pulumi.aws.s3

@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Nov 26, 2024
@Frassle Frassle transferred this issue from pulumi/pulumi Nov 26, 2024
@Frassle
Copy link
Member

Frassle commented Nov 26, 2024

Originally moved this to the Java repo, as at a glance it looked like a Java codegen bug. But looking into it this actually affects all the languages. So moving this to the aws repo as it's a general issue with the schema name.

@Frassle Frassle transferred this issue from pulumi/pulumi-java Nov 26, 2024
@flostadler
Copy link
Contributor

The provider currently refers to this resource by the name BucketObjectv2 (instead of V2 like BucketV2 for example). This was most likely done by accident (introduced here).

Changing this now to align it with the other s3 V2 resources would require a breaking change. But we have an opportunity to align this in the next major version

@flostadler flostadler added kind/bug Some behavior is incorrect or out of spec impact/breaking Fixing this issue will require a breaking change and removed needs-triage Needs attention from the triage team labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/breaking Fixing this issue will require a breaking change kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Development

No branches or pull requests

4 participants