Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfolded Add Node in Network Graph related to the rounding #9

Open
ahmad-mirsalari opened this issue Jul 25, 2023 · 1 comment
Open

Comments

@ahmad-mirsalari
Copy link

I have noticed an issue in the commit (e8cfc0d), specifically in the graph of the network.

There is an Add node for rounding (0.5), which should ideally be folded together with the other Add node before it. This seems to be causing a discrepancy in the network graph.

Could this be checked and corrected?

Thanks for looking into this.
add

@Scheremo
Copy link
Collaborator

Hi @ahmad-mirsalari!
I believe this is in issue of oversight. For PULP-NN type quantization, the rounding offset (eps/2) is indeed added to the bias of the requantization operator. For CMSIS type quantization, this is not done, since the kernels work differently. I'll look into a fix with @da-gazzi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@Scheremo @ahmad-mirsalari and others