Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor_package files are not added as source #136

Open
sazam0 opened this issue Sep 7, 2023 · 1 comment
Open

vendor_package files are not added as source #136

sazam0 opened this issue Sep 7, 2023 · 1 comment

Comments

@sazam0
Copy link

sazam0 commented Sep 7, 2023

following is my vendor_package settings:

vendor_package:
  - name: bextdep
    target_dir: vendor/bextdep
    upstream: { git: "https://github.com/cliffordwolf/bextdep.git", rev: "b96198514856bfaf85db3e7b0cb1d5f7e0c06d68" }
    include_from_upstream:
      - "bextdep.v"
      - "bextdep_pps.v"

bender script vivado-sim -t rtl -t test includes files from sources as expected but does not include the bextdep.v and bextdep_pps.v

@micprog
Copy link
Member

micprog commented Dec 29, 2023

The vendor package section is designed to be an add-on feature only used for the bender vendor command. As the vendor can also include all files and directories from an upstream dependency, not specifying individual files, the files specified in include_from_upstream are not used for the bender sources command. Please specify your required files again in the sources section of the Bender.yml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants