-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed border shadow for input box on focus #9634
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really great @Dandu-Rajeev but the comment you added is not necessary. Would you mind removing it and then add a screenshot of the changes you made.
Thanks.
Code Climate has analyzed commit 12fec8f and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the code as per review comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
What's next, @TildaDares? |
@Dandu-Rajeev We'll wait for a reviewer to approve this. Could you add a screenshot of the change(s) you made? |
|
@Dandu-Rajeev I'm sorry if I wasn't clear enough. I meant an image of the search box after you applied the changes. |
@TildaDares I have checked the changes using GitPod and observed that the changes are not getting reflected. I also observed that the styles in app/assets/stylesheets/styles.css are not getting applied. Request you to check and let me know how to proceed. Thanks |
@Dandu-Rajeev Is your local env set up? |
@TildaDares No. I faced few issues and got confused during setup. :( |
@Dandu-Rajeev Okay |
Codecov Report
@@ Coverage Diff @@
## main #9634 +/- ##
=======================================
Coverage ? 74.07%
=======================================
Files ? 98
Lines ? 6053
Branches ? 0
=======================================
Hits ? 4484
Misses ? 1569
Partials ? 0 |
Looking great from gitpod...Thanks everyone 🎉 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely!!!:tada: :tada:
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Thank you for merging my pull request. Learnt a lot! |
* Fixed border shadow for input box on focus * Removed comment as suggested
* Fixed border shadow for input box on focus * Removed comment as suggested
Fixes #9624 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!