Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed border shadow for input box on focus #9634

Merged
merged 2 commits into from
May 18, 2021

Conversation

Dandu-Rajeev
Copy link
Contributor

Fixes #9624 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • [✔️] PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • [✔️] code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented May 16, 2021

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄

@gitpod-io
Copy link

gitpod-io bot commented May 16, 2021

@Dandu-Rajeev Dandu-Rajeev marked this pull request as ready for review May 16, 2021 14:33
Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great @Dandu-Rajeev but the comment you added is not necessary. Would you mind removing it and then add a screenshot of the changes you made.

Thanks.

@codeclimate
Copy link

codeclimate bot commented May 16, 2021

Code Climate has analyzed commit 12fec8f and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor Author

@Dandu-Rajeev Dandu-Rajeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the code as per review comments.

Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Dandu-Rajeev
Copy link
Contributor Author

What's next, @TildaDares?

@TildaDares
Copy link
Member

@Dandu-Rajeev We'll wait for a reviewer to approve this. Could you add a screenshot of the change(s) you made?

@Dandu-Rajeev
Copy link
Contributor Author

image
I believe you're asking for code changes @TildaDares.

@TildaDares
Copy link
Member

@Dandu-Rajeev I'm sorry if I wasn't clear enough. I meant an image of the search box after you applied the changes.

@Dandu-Rajeev
Copy link
Contributor Author

@TildaDares I have checked the changes using GitPod and observed that the changes are not getting reflected. I also observed that the styles in app/assets/stylesheets/styles.css are not getting applied. Request you to check and let me know how to proceed. Thanks

@TildaDares
Copy link
Member

@Dandu-Rajeev Is your local env set up?

@Dandu-Rajeev
Copy link
Contributor Author

@TildaDares No. I faced few issues and got confused during setup. :(

@TildaDares
Copy link
Member

@Dandu-Rajeev Okay

@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@3e51db2). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head d7f84a0 differs from pull request most recent head 12fec8f. Consider uploading reports for the commit 12fec8f to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9634   +/-   ##
=======================================
  Coverage        ?   74.07%           
=======================================
  Files           ?       98           
  Lines           ?     6053           
  Branches        ?        0           
=======================================
  Hits            ?     4484           
  Misses          ?     1569           
  Partials        ?        0           

@cesswairimu
Copy link
Collaborator

Looking great from gitpod...Thanks everyone 🎉 🎉

Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!!!:tada: :tada:

@cesswairimu cesswairimu merged commit 6ef5e49 into publiclab:main May 18, 2021
@welcome
Copy link

welcome bot commented May 18, 2021

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@Dandu-Rajeev
Copy link
Contributor Author

Thank you for merging my pull request. Learnt a lot!

reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
* Fixed border shadow for input box on focus

* Removed comment as suggested
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
* Fixed border shadow for input box on focus

* Removed comment as suggested
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing search input box shadow style
3 participants