Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the /wiki page display unique results #9592

Merged
merged 3 commits into from
May 7, 2021

Conversation

Manasa2850
Copy link
Member

@Manasa2850 Manasa2850 commented May 2, 2021

Fixes #9591 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@gitpod-io
Copy link

gitpod-io bot commented May 2, 2021

@Manasa2850
Copy link
Member Author

Before
temp

After
temp1

@codecov
Copy link

codecov bot commented May 2, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@c958118). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9592   +/-   ##
=======================================
  Coverage        ?   81.47%           
=======================================
  Files           ?       98           
  Lines           ?     5927           
  Branches        ?        0           
=======================================
  Hits            ?     4829           
  Misses          ?     1098           
  Partials        ?        0           

@RuthNjeri
Copy link
Contributor

Thanks for working on this @Manasa2850, would you like to add tests for these changes?

@Manasa2850
Copy link
Member Author

Sure @RuthNjeri I'll do that!

@Manasa2850 Manasa2850 requested a review from RuthNjeri May 2, 2021 19:50
@codeclimate
Copy link

codeclimate bot commented May 5, 2021

Code Climate has analyzed commit 5ae1351 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@RuthNjeri RuthNjeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me @Manasa2850, thank you! 🎉

@RuthNjeri RuthNjeri merged commit 9b60ef6 into publiclab:main May 7, 2021
@RuthNjeri
Copy link
Contributor

@Manasa2850 I still see some duplicates for the wiki page on the stable site, perhaps you could investigate it?
https://stable.publiclab.org/wiki
Screenshot 2021-05-07 at 21 49 17

@Manasa2850
Copy link
Member Author

@RuthNjeri I'll try to find out why that's happening.
Thanks!

reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
* added uniq constraint

* added functional test

* check based on id and not title
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
* added uniq constraint

* added functional test

* check based on id and not title
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wikis don't display unique results
2 participants