-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the /wiki page display unique results #9592
Conversation
Codecov Report
@@ Coverage Diff @@
## main #9592 +/- ##
=======================================
Coverage ? 81.47%
=======================================
Files ? 98
Lines ? 5927
Branches ? 0
=======================================
Hits ? 4829
Misses ? 1098
Partials ? 0 |
Thanks for working on this @Manasa2850, would you like to add tests for these changes? |
Sure @RuthNjeri I'll do that! |
Code Climate has analyzed commit 5ae1351 and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me @Manasa2850, thank you! 🎉
@Manasa2850 I still see some duplicates for the wiki page on the stable site, perhaps you could investigate it? |
@RuthNjeri I'll try to find out why that's happening. |
* added uniq constraint * added functional test * check based on id and not title
* added uniq constraint * added functional test * check based on id and not title
Fixes #9591 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!