Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the arial label misspell #9565

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Fix the arial label misspell #9565

merged 1 commit into from
Apr 27, 2021

Conversation

j-saurabh
Copy link
Contributor

Fixes #9561 (Fix misspelled aria labels)

Fixed the spelling in the file https://github.com/publiclab/plots2/search?q=aria-hiddden.

The issue raised for this was : #9561

Let me know in case of any issues

@welcome
Copy link

welcome bot commented Apr 27, 2021

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄

@gitpod-io
Copy link

gitpod-io bot commented Apr 27, 2021

@codeclimate
Copy link

codeclimate bot commented Apr 27, 2021

Code Climate has analyzed commit 8e4fcf6 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM🎉

@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@dbe0db5). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 04ca95b differs from pull request most recent head 8e4fcf6. Consider uploading reports for the commit 8e4fcf6 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9565   +/-   ##
=======================================
  Coverage        ?   79.69%           
=======================================
  Files           ?       98           
  Lines           ?     5944           
  Branches        ?        0           
=======================================
  Hits            ?     4737           
  Misses          ?     1207           
  Partials        ?        0           

Copy link
Contributor

@sahilsaha7773 sahilsaha7773 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jywarren
Copy link
Member

This looks great! I'm not sure why the system tests failed; the error was pretty mysterious (see below). I just restarted the tests to see if it was just something random and unrelated. 🤷

2021-04-27 09:53:01 +0000 Rack app ("POST /comment/create/56" - (127.0.0.1)): Mysql2::Error
=============[Screenshot]: tmp/screenshots/failures_test_post_note,_then_comment_on_FRESH_note.png
ERROR CommentTest#test_post_note,_then_comment_on_FRESH_note (323.54s)
Minitest::UnexpectedError:         Mysql2::Error: 
            app/models/tag.rb:430:in `update_tags_activity'
            app/models/node.rb:678:in `tag_activity'
            app/models/node.rb:671:in `add_comment'
            app/helpers/comment_helper.rb:6:in `create_comment'
            app/controllers/comment_controller.rb:26:in `create'

@jywarren
Copy link
Member

Hooray, it was unrelated!!! Merging now. Thanks everyone!!!

@jywarren jywarren merged commit dcc7422 into publiclab:main Apr 27, 2021
@welcome
Copy link

welcome bot commented Apr 27, 2021

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@j-saurabh
Copy link
Contributor Author

Thank you everyone!!! This is my first contribution, a very tiny contribution towards open source. But it is kind of an accomplishment to me. Looking forward to making more and more contribution in open source.

@j-saurabh j-saurabh deleted the fix-arial_label branch April 28, 2021 13:43
@j-saurabh j-saurabh restored the fix-arial_label branch April 28, 2021 13:43
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix misspelled aria labels
4 participants