-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the arial label misspell #9565
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Code Climate has analyzed commit 8e4fcf6 and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM🎉
Codecov Report
@@ Coverage Diff @@
## main #9565 +/- ##
=======================================
Coverage ? 79.69%
=======================================
Files ? 98
Lines ? 5944
Branches ? 0
=======================================
Hits ? 4737
Misses ? 1207
Partials ? 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This looks great! I'm not sure why the system tests failed; the error was pretty mysterious (see below). I just restarted the tests to see if it was just something random and unrelated. 🤷
|
Hooray, it was unrelated!!! Merging now. Thanks everyone!!! |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Thank you everyone!!! This is my first contribution, a very tiny contribution towards open source. But it is kind of an accomplishment to me. Looking forward to making more and more contribution in open source. |
Fixes #9561 (Fix misspelled aria labels)
Fixed the spelling in the file https://github.com/publiclab/plots2/search?q=aria-hiddden.
The issue raised for this was : #9561
Let me know in case of any issues