Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing envvars to docker-compose to fix SMTP errors in Sidekiq #9534

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

icarito
Copy link
Member

@icarito icarito commented Apr 20, 2021

We've had some errors from Sidekiq that it could not find the smtp host: https://sentry.io/share/issue/e1e982cd853e40abb440c7d4f40755b2/

It was missing references to the SMTP server. Previously this was fine as we were using the default configuration.

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@gitpod-io
Copy link

gitpod-io bot commented Apr 20, 2021

@icarito icarito changed the title Add some missing envvars to docker-compose config Add missing envvars to docker-compose to fix SMTP errors in Sidekiq Apr 20, 2021
@codeclimate
Copy link

codeclimate bot commented Apr 20, 2021

Code Climate has analyzed commit d310c41 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@bd0bc11). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9534   +/-   ##
=======================================
  Coverage        ?   81.38%           
=======================================
  Files           ?       98           
  Lines           ?     5924           
  Branches        ?        0           
=======================================
  Hits            ?     4821           
  Misses          ?     1103           
  Partials        ?        0           

@icarito
Copy link
Member Author

icarito commented Apr 20, 2021

I've put the SMTP lines in docker-compose-production to test as a hotfix. We should now stop seeing this error in Sentry for production.

@icarito
Copy link
Member Author

icarito commented Apr 20, 2021

This seems to have had the desired effect as a hotfix. Let's merge it.

@jywarren jywarren merged commit fb890a7 into main Apr 27, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants