Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide datepicker on clicking save button #9521

Merged
merged 1 commit into from
Apr 18, 2021
Merged

Conversation

roli25
Copy link
Contributor

@roli25 roli25 commented Apr 16, 2021

Fixes #9516

@gitpod-io
Copy link

gitpod-io bot commented Apr 16, 2021

@codeclimate
Copy link

codeclimate bot commented Apr 16, 2021

Code Climate has analyzed commit 4a37ad1 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@ebaad12). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 24eeb06 differs from pull request most recent head 4a37ad1. Consider uploading reports for the commit 4a37ad1 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9521   +/-   ##
=======================================
  Coverage        ?   79.70%           
=======================================
  Files           ?       98           
  Lines           ?     5956           
  Branches        ?        0           
=======================================
  Hits            ?     4747           
  Misses          ?     1209           
  Partials        ?        0           

@roli25
Copy link
Contributor Author

roli25 commented Apr 16, 2021

@cesswairimu Please review it.

Copy link
Contributor

@sahilsaha7773 sahilsaha7773 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @roli25! Thanks for opening this PR, it looks good to me!!! Please wait for the collaborators to review.

@waridrox
Copy link
Member

Hi @roli25, thanks for opening this PR 🎉. Please edit the comment message to include any gif image / vid clip that reflects the above changes made 🙌.

I also noticed that multiple PRs were closed including #9518, #9519 and #9520 related to fixing the issue 😅. You don't need to do this every time to make any further changes. You can make the necessary changes(commits) in the same PR instead of creating a new one. Please keep that in mind from next time onwards and ask for help if required✌️. Thanks :)

@RuthNjeri
Copy link
Contributor

Thanks, @roli25! 🎉 great work.

Thank you for the awesome reviews @waridrox and @sahilsaha7773 ❤️

@RuthNjeri RuthNjeri merged commit 44afb74 into publiclab:main Apr 18, 2021
@welcome
Copy link

welcome bot commented Apr 18, 2021

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide datepicker on clicking save button
4 participants