-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hide datepicker on clicking save button #9521
Conversation
Code Climate has analyzed commit 4a37ad1 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #9521 +/- ##
=======================================
Coverage ? 79.70%
=======================================
Files ? 98
Lines ? 5956
Branches ? 0
=======================================
Hits ? 4747
Misses ? 1209
Partials ? 0 |
@cesswairimu Please review it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @roli25! Thanks for opening this PR, it looks good to me!!! Please wait for the collaborators to review.
Hi @roli25, thanks for opening this PR 🎉. Please edit the comment message to include any gif image / vid clip that reflects the above changes made 🙌. I also noticed that multiple PRs were closed including #9518, #9519 and #9520 related to fixing the issue 😅. You don't need to do this every time to make any further changes. You can make the necessary changes(commits) in the same PR instead of creating a new one. Please keep that in mind from next time onwards and ask for help if required✌️. Thanks :) |
Thanks, @roli25! 🎉 great work. Thank you for the awesome reviews @waridrox and @sahilsaha7773 ❤️ |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Fixes #9516