Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move csrf token into formdata for PublicLab.Editor richTextModule #9504

Merged
merged 2 commits into from
Apr 13, 2021

Conversation

jywarren
Copy link
Member

ref #9438

@jywarren jywarren requested a review from a team as a code owner April 13, 2021 20:32
@gitpod-io
Copy link

gitpod-io bot commented Apr 13, 2021

@jywarren jywarren mentioned this pull request Apr 13, 2021
@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@6168103). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 94eb3e5 differs from pull request most recent head 7b8e4f8. Consider uploading reports for the commit 7b8e4f8 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9504   +/-   ##
=======================================
  Coverage        ?   81.50%           
=======================================
  Files           ?       98           
  Lines           ?     5938           
  Branches        ?        0           
=======================================
  Hits            ?     4840           
  Misses          ?     1098           
  Partials        ?        0           

@jywarren
Copy link
Member Author

French translation error:


Minitest::UnexpectedError:         ActionView::Template::Error: missing interpolation argument :search in "Aucun résultat trouvé en cherchant \"%{search}\"" ({:tag=>"some-tag"} given)
            app/helpers/application_helper.rb:158:in `translation'
            app/views/tag/widget.html.erb:14:in `_app_views_tag_widget_html_erb__3684193017882036563_47228995284600'
            app/controllers/tag_controller.rb:250:in `widget'
            test/integration/I18n_test.rb:425:in `block (2 levels) in <class:I18nTest>'
            test/integration/I18n_test.rb:421:in `each'
            test/integration/I18n_test.rb:421:in `block in <class:I18nTest>'

== FAIL I18nTest#test_should_choose_i18n_for_user/_form_+_user/new (224.46s)
        <Nom d'utilisateur·ice> expected but was
        <Nom d'utilisat⋅eur·ice>..
        Expected 0 to be >= 1.
        test/integration/I18n_test.rb:198:in `block (2 levels) in <class:I18nTest>'
        test/integration/I18n_test.rb:194:in `each'
        test/integration/I18n_test.rb:194:in `block in <class:I18nTest>'

@codeclimate
Copy link

codeclimate bot commented Apr 13, 2021

Code Climate has analyzed commit 7b8e4f8 and detected 0 issues on this pull request.

View more on Code Climate.

@jywarren
Copy link
Member Author

Once merged, let's do #9506

@jywarren jywarren merged commit 1a6ae29 into main Apr 13, 2021
jywarren added a commit that referenced this pull request May 11, 2021
jywarren added a commit that referenced this pull request May 18, 2021
* 2nd attempt to add French translations

Building on #9481 and #9504!

* Update and rename for_use_publiclaborg_en-yml--master_fr.yml to fr.yml

* swap \" for '

* change "search" param to "tag"
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
…bliclab#9504)

* move csrf token into formdata for PublicLab.Editor richTextModule

ref publiclab#9438

* remove ", :fr" from application.rb re publiclab#9481
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
* 2nd attempt to add French translations

Building on publiclab#9481 and publiclab#9504!

* Update and rename for_use_publiclaborg_en-yml--master_fr.yml to fr.yml

* swap \" for '

* change "search" param to "tag"
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
…bliclab#9504)

* move csrf token into formdata for PublicLab.Editor richTextModule

ref publiclab#9438

* remove ", :fr" from application.rb re publiclab#9481
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
* 2nd attempt to add French translations

Building on publiclab#9481 and publiclab#9504!

* Update and rename for_use_publiclaborg_en-yml--master_fr.yml to fr.yml

* swap \" for '

* change "search" param to "tag"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant