Fix ActiveRecord::RecordNotFound when clicking on 'step-by-step activity'

[aliciapaz]

Fixes #9475
This fixes the error by removing the missing id from the URL. However, I'm concerned about this not being a solution but just a workaround.

It would be helpful to understand:
What does this id do in that URL? why is that node missing?

Thanks in advance 😸

[gitpod-io]

[codeclimate]

Code Climate has analyzed commit f05fcee and detected 0 issues on this pull request.

View more on Code Climate.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (main@8c729b2). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 188a3de differs from pull request most recent head f05fcee. Consider uploading reports for the commit f05fcee to get more accurate results

@@           Coverage Diff           @@
##             main    #9503   +/-   ##
=======================================
  Coverage        ?   56.88%           
=======================================
  Files           ?       98           
  Lines           ?     6111           
  Branches        ?        0           
=======================================
  Hits            ?     3476           
  Misses          ?     2635           
  Partials        ?        0           

[cesswairimu]

Hi @aliciapaz , looks likes there are some failing tests on tags that do not seem to be related to your changes

===ERROR I18nTest#test_should_choose_i18n_for_tag/show (209.45s)
Minitest::UnexpectedError:         ActionView::Template::Error: missing interpolation argument :search in "Aucun résultat trouvé en cherchant \"%{search}\"" ({:tag=>"some-tag"} given)
            app/helpers/application_helper.rb:158:in `translation'
            app/views/tag/show/_tab_content.html.erb:10:in `_app_views_tag_show__tab_content_html_erb__2599195840854876495_47384223172900'
            app/views/tag/show.html.erb:158:in `block in _app_views_tag_show_html_erb___2792876303108153280_47384223051420'
            app/views/tag/show.html.erb:149:in `_app_views_tag_show_html_erb___2792876303108153280_47384223051420'
            app/controllers/tag_controller.rb:161:in `block (2 levels) in show'
            app/controllers/tag_controller.rb:160:in `show'
            test/integration/I18n_test.rb:415:in `block (2 levels) in <class:I18nTest>'
            test/integration/I18n_test.rb:411:in `each'
            test/integration/I18n_test.rb:411:in `block in <class:I18nTest>'

=ERROR I18nTest#test_should_choose_i18n_for_tag/widget (210.08s)
Minitest::UnexpectedError:         ActionView::Template::Error: missing interpolation argument :search in "Aucun résultat trouvé en cherchant \"%{search}\"" ({:tag=>"some-tag"} given)
            app/helpers/application_helper.rb:158:in `translation'
            app/views/tag/widget.html.erb:14:in `_app_views_tag_widget_html_erb__1813037706612507661_47384203707320'
            app/controllers/tag_controller.rb:250:in `widget'
            test/integration/I18n_test.rb:425:in `block (2 levels) in <class:I18nTest>'
            test/integration/I18n_test.rb:421:in `each'
            test/integration/I18n_test.rb:421:in `block in <class:I18nTest>'

= FAIL I18nTest#test_should_choose_i18n_for_user/_form_+_user/new (211.99s)
        <Nom d'utilisateur·ice> expected but was
        <Nom d'utilisat⋅eur·ice>..
        Expected 0 to be >= 1.
        test/integration/I18n_test.rb:198:in `block (2 levels) in <class:I18nTest>'
        test/integration/I18n_test.rb:194:in `each'
        test/integration/I18n_test.rb:194:in `block in <class:I18nTest>'

I will try and restart the build. Thanks for working on this

[gitpod-io]

[RuthNjeri]

Thanks, @aliciapaz. This looks good to me. You can rebase/squash to reduce the number of commits.

[RuthNjeri]

I have actually done a squash through the merge. Thanks again @aliciapaz

[RuthNjeri]

Please have a look at #9511, it would seem that removing the nid would remove a reference to the node that inserts pre-existing text.