-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unneeded webpacker/react install command from Makefile #9501
Conversation
Command was needed at installation time only.
#9176 This references the webpack installation issue we faced previously. |
Codecov Report
@@ Coverage Diff @@
## main #9501 +/- ##
=======================================
Coverage ? 81.50%
=======================================
Files ? 98
Lines ? 5938
Branches ? 0
=======================================
Hits ? 4840
Misses ? 1098
Partials ? 0 |
Cool! Remember to merge before deploying. |
Actually I'll merge it! |
Code Climate has analyzed commit 9633fd7 and detected 0 issues on this pull request. View more on Code Climate. |
Command was needed at installation time only.
Command was needed at installation time only.
Command was needed at installation time only.
Fixes #0000 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!