Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded webpacker/react install command from Makefile #9501

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

icarito
Copy link
Member

@icarito icarito commented Apr 13, 2021

Command was needed at installation time only.

Fixes #0000 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

Command was needed at installation time only.
@gitpod-io
Copy link

gitpod-io bot commented Apr 13, 2021

@icarito
Copy link
Member Author

icarito commented Apr 13, 2021

#9176 This references the webpack installation issue we faced previously.

@icarito
Copy link
Member Author

icarito commented Apr 13, 2021

@jywarren @noi5e I wonder if #9392 was really necessary too?

@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@bd7b2e2). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 9310fab differs from pull request most recent head 9633fd7. Consider uploading reports for the commit 9633fd7 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9501   +/-   ##
=======================================
  Coverage        ?   81.50%           
=======================================
  Files           ?       98           
  Lines           ?     5938           
  Branches        ?        0           
=======================================
  Hits            ?     4840           
  Misses          ?     1098           
  Partials        ?        0           

@jywarren jywarren changed the title Remove unneeded command Remove unneeded webpacker/react install command from Makefile Apr 13, 2021
@icarito
Copy link
Member Author

icarito commented Apr 13, 2021

Cool! Remember to merge before deploying.

@icarito
Copy link
Member Author

icarito commented Apr 13, 2021

Actually I'll merge it!

@codeclimate
Copy link

codeclimate bot commented Apr 13, 2021

Code Climate has analyzed commit 9633fd7 and detected 0 issues on this pull request.

View more on Code Climate.

@icarito icarito merged commit 5c49c19 into main Apr 20, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
Command was needed at installation time only.
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Command was needed at installation time only.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants