-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated line 7 with revised translation helper #9477
Updated line 7 with revised translation helper #9477
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Codecov Report
@@ Coverage Diff @@
## main #9477 +/- ##
=======================================
Coverage ? 81.36%
=======================================
Files ? 98
Lines ? 5930
Branches ? 0
=======================================
Hits ? 4825
Misses ? 1105
Partials ? 0 |
Code Climate has analyzed commit 7e88903 and detected 0 issues on this pull request. View more on Code Climate. |
Thanks @MohammedHamzaMalik for the PR. Small nit, it would be great if you could make the PR title more descriptive of what it intends to do. Rest LGTM 🎉 cc @publiclab/plots2-reviewers |
Thank you @MohammedHamzaMalik and thanks to @daemon1024 for the review! Much appreciated, both of you!!!! |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
This looks great!!! |
Fixes #9250