Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated line 7 with revised translation helper #9477

Conversation

MohammedHamzaMalik
Copy link
Contributor

Fixes #9250

@welcome
Copy link

welcome bot commented Apr 8, 2021

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄

@gitpod-io
Copy link

gitpod-io bot commented Apr 8, 2021

@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@44d629b). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 1fedf86 differs from pull request most recent head 7e88903. Consider uploading reports for the commit 7e88903 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9477   +/-   ##
=======================================
  Coverage        ?   81.36%           
=======================================
  Files           ?       98           
  Lines           ?     5930           
  Branches        ?        0           
=======================================
  Hits            ?     4825           
  Misses          ?     1105           
  Partials        ?        0           

@codeclimate
Copy link

codeclimate bot commented Apr 8, 2021

Code Climate has analyzed commit 7e88903 and detected 0 issues on this pull request.

View more on Code Climate.

@daemon1024
Copy link
Member

Thanks @MohammedHamzaMalik for the PR. Small nit, it would be great if you could make the PR title more descriptive of what it intends to do. Rest LGTM 🎉

cc @publiclab/plots2-reviewers

@jywarren jywarren changed the title Updated line 7 Updated line 7 with revised translation helper Apr 9, 2021
@jywarren
Copy link
Member

jywarren commented Apr 9, 2021

Thank you @MohammedHamzaMalik and thanks to @daemon1024 for the review! Much appreciated, both of you!!!!

@jywarren jywarren merged commit aa2f71f into publiclab:main Apr 9, 2021
@welcome
Copy link

welcome bot commented Apr 9, 2021

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@jywarren
Copy link
Member

jywarren commented Apr 9, 2021

This looks great!!!

reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Questions: _recent_questions_shadow.html.erb Translation
3 participants