-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grammar fix Issue 9451 #9452
Grammar fix Issue 9451 #9452
Conversation
fix grammatical error in the README file.
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Code Climate has analyzed commit 6fb0f1a and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #9452 +/- ##
=======================================
Coverage ? 58.32%
=======================================
Files ? 98
Lines ? 5991
Branches ? 0
=======================================
Hits ? 3494
Misses ? 2497
Partials ? 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Elukoye, please update the PR template by putting x
in the checkboxes area wherever applicable.
Other than that LGTM 😄 🎉.
@waridrox , can you please check if I have done the correct thing ? |
Yes, I've checked it! 🚀 |
@Elukoye LGTM |
@waridrox what happens next ? You merge 👍 ? |
@Elukoye, just be patient and reviewers with write access will get it merged asap 😄. Meanwhile you can try to solve other issues ✌️ |
@waridrox ok 😀 |
@Elukoye I was thinking of working on this issue and found some additional changes that can be made under this issue can we collaborate together and send an updated pull request |
Hi @NishantJawla 😄, I think it would better to open an issue addressing the changes that you are thinking of and make a PR accordingly rather than making changes in this PR. Thanks :) |
@waridrox Thanks for the advice will do so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Awesome 🎉 thanks for working on this @Elukoye |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
@NishantJawla, do you still want to collaborate? |
Yeah! You can contact me on Twitter (@jawla_nishant) |
fix grammatical error in the README file.
fix grammatical error in the README file.
fix grammatical error in the README file.
Fixes #9451 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!