-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solved the issue of vertical align of Public lab tittle in navbar #9434
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Code Climate has analyzed commit 79b1fc8 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #9434 +/- ##
=======================================
Coverage ? 79.68%
=======================================
Files ? 98
Lines ? 5950
Branches ? 0
=======================================
Hits ? 4741
Misses ? 1209
Partials ? 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @SharmaTanish LGTM 🎉
This looks super. Thank you so much!!!! |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Thank you @jywarren @Tlazypanda for your support !😀 |
Fixes #6446
I have resolved the above mentioned issue and now the tittle of PublicLab is perfectly aligned on any screen width as you can see in the below screenshot .
Changes I made
I have changes few lines of code in
app/assets/stylesheets/style.css
file and now it become perfectly responsive .@RuthNjeri please have a look on this .
Checklist
rake test
@publiclab/reviewers
for help, in a comment below