Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved the issue of vertical align of Public lab tittle in navbar #9434

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

SharmaTanish
Copy link
Contributor

Fixes #6446

I have resolved the above mentioned issue and now the tittle of PublicLab is perfectly aligned on any screen width as you can see in the below screenshot .

Changes I made

I have changes few lines of code in app/assets/stylesheets/style.css file and now it become perfectly responsive .
@RuthNjeri please have a look on this .

Checklist

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

public lab tittle

@welcome
Copy link

welcome bot commented Apr 3, 2021

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄

@gitpod-io
Copy link

gitpod-io bot commented Apr 3, 2021

@codeclimate
Copy link

codeclimate bot commented Apr 3, 2021

Code Climate has analyzed commit 79b1fc8 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Apr 3, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@a44aff7). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 0d5df66 differs from pull request most recent head 79b1fc8. Consider uploading reports for the commit 79b1fc8 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9434   +/-   ##
=======================================
  Coverage        ?   79.68%           
=======================================
  Files           ?       98           
  Lines           ?     5950           
  Branches        ?        0           
=======================================
  Hits            ?     4741           
  Misses          ?     1209           
  Partials        ?        0           

Copy link
Collaborator

@Tlazypanda Tlazypanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @SharmaTanish LGTM 🎉

@jywarren
Copy link
Member

jywarren commented Apr 9, 2021

This looks super. Thank you so much!!!!

@jywarren jywarren merged commit b051096 into publiclab:main Apr 9, 2021
@welcome
Copy link

welcome bot commented Apr 9, 2021

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@SharmaTanish
Copy link
Contributor Author

Thank you @jywarren @Tlazypanda for your support !😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vertically center align menu button and title in header
3 participants