Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore empty string in SMTP configuration #9413

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Conversation

icarito
Copy link
Member

@icarito icarito commented Mar 31, 2021

This PR fixes an issue found in #9043 because docker-compose declares missing environment variables with an empty string. This patch fixes configuration of production to ignore empty strings.

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@gitpod-io
Copy link

gitpod-io bot commented Mar 31, 2021

@codeclimate
Copy link

codeclimate bot commented Mar 31, 2021

Code Climate has analyzed commit 79b3c2d and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@04bb121). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 0eb5af7 differs from pull request most recent head 79b3c2d. Consider uploading reports for the commit 79b3c2d to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9413   +/-   ##
=======================================
  Coverage        ?   81.48%           
=======================================
  Files           ?       98           
  Lines           ?     5930           
  Branches        ?        0           
=======================================
  Hits            ?     4832           
  Misses          ?     1098           
  Partials        ?        0           

@icarito
Copy link
Member Author

icarito commented Apr 6, 2021

Remember to merge this before deploying again to production. This was implemented as a hotfix last week and is already in production.

@jywarren jywarren merged commit 25252af into main Apr 15, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants