Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display notification when a user likes/dislikes a note #9385

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

jcads
Copy link
Contributor

@jcads jcads commented Mar 29, 2021

Fixes #9353.

feature preview:
Screencast-2021-03-28-171020


Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@welcome
Copy link

welcome bot commented Mar 29, 2021

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄

@gitpod-io
Copy link

gitpod-io bot commented Mar 29, 2021

@codeclimate
Copy link

codeclimate bot commented Mar 29, 2021

Code Climate has analyzed commit 20f6807 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@c9daa81). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 90fe18c differs from pull request most recent head 20f6807. Consider uploading reports for the commit 20f6807 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9385   +/-   ##
=======================================
  Coverage        ?   81.48%           
=======================================
  Files           ?       98           
  Lines           ?     5930           
  Branches        ?        0           
=======================================
  Hits            ?     4832           
  Misses          ?     1098           
  Partials        ?        0           

@noi5e
Copy link
Contributor

noi5e commented Mar 30, 2021

@jcads Thanks for this!!! It looks great. I will look over this and give a more detailed review later today, just wanted to say that this hasn't fallen off my radar.

Copy link
Member

@pydevsg pydevsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @jcads 💯
@publiclab/maintainers merge this .

Copy link
Collaborator

@Tlazypanda Tlazypanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcads LGTM 🎉

@cesswairimu
Copy link
Collaborator

Thanks @jcads for working on this 🎉
Thanks @noi5e @pydevsg @Tlazypanda for the reviews 🎉 🎉
Merging now 🚀

@cesswairimu cesswairimu merged commit 1183765 into publiclab:main Apr 8, 2021
@jcads jcads deleted the like-notif branch April 8, 2021 09:53
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display Notification When User Likes Research Note
5 participants