-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display notification when a user likes/dislikes a note #9385
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Code Climate has analyzed commit 20f6807 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #9385 +/- ##
=======================================
Coverage ? 81.48%
=======================================
Files ? 98
Lines ? 5930
Branches ? 0
=======================================
Hits ? 4832
Misses ? 1098
Partials ? 0 |
@jcads Thanks for this!!! It looks great. I will look over this and give a more detailed review later today, just wanted to say that this hasn't fallen off my radar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @jcads 💯
@publiclab/maintainers merge this .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jcads LGTM 🎉
Thanks @jcads for working on this 🎉 |
Fixes #9353.
feature preview:
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment below