Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bounce non-user email replies #9126

Merged
merged 7 commits into from
May 4, 2021
Merged

Bounce non-user email replies #9126

merged 7 commits into from
May 4, 2021

Conversation

Manasa2850
Copy link
Member

@Manasa2850 Manasa2850 commented Feb 4, 2021

Fixes #3322 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@Manasa2850 Manasa2850 requested a review from a team as a code owner February 4, 2021 11:35
@gitpod-io
Copy link

gitpod-io bot commented Feb 4, 2021

app/models/comment.rb Outdated Show resolved Hide resolved
app/models/comment.rb Outdated Show resolved Hide resolved
app/models/comment.rb Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@0707e3e). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head ee8a0e9 differs from pull request most recent head 6f5eb32. Consider uploading reports for the commit 6f5eb32 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9126   +/-   ##
=======================================
  Coverage        ?   49.68%           
=======================================
  Files           ?       98           
  Lines           ?     6107           
  Branches        ?        0           
=======================================
  Hits            ?     3034           
  Misses          ?     3073           
  Partials        ?        0           

@Manasa2850
Copy link
Member Author

@jywarren I've used regex to get the email ID and sending an email using ActionMailer. Is this fine?
Also, what should be the sender's email ID... Do we have a public lab email ID that I need to put there?
Thank you!

@Manasa2850 Manasa2850 requested a review from jywarren February 4, 2021 12:21
@RuthNjeri RuthNjeri closed this Feb 4, 2021
@RuthNjeri RuthNjeri reopened this Feb 4, 2021
@gitpod-io
Copy link

gitpod-io bot commented Feb 4, 2021

app/models/comment.rb Outdated Show resolved Hide resolved
@Manasa2850
Copy link
Member Author

@jywarren regarding sending back an email in case of other errors, I checked the rescue Exception code in script/mailman_server. But it seems like we commented it out since it caused the site to slowdown. Should we have it back or keep it as it is for now?
Thank you!

@jywarren
Copy link
Member

jywarren commented May 4, 2021

Hi, unfortunately the rescue is bad for memory management it seems, so let's keep it. Thank you @Manasa2850 and apologies for the slow reply!

@gitpod-io
Copy link

gitpod-io bot commented May 4, 2021

app/models/comment.rb Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented May 4, 2021

Code Climate has analyzed commit 6f5eb32 and detected 0 issues on this pull request.

View more on Code Climate.

@jywarren jywarren merged commit 8daad1a into publiclab:main May 4, 2021
@jywarren
Copy link
Member

jywarren commented May 4, 2021

Awesome work, thank you!!!

reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
* added reply email

* resolve merge conflict

* trigger build

* Update app/models/comment.rb

* Update app/models/comment.rb

Co-authored-by: Jeffrey Warren <[email protected]>
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
* added reply email

* resolve merge conflict

* trigger build

* Update app/models/comment.rb

* Update app/models/comment.rb

Co-authored-by: Jeffrey Warren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bounce non-user email replies and errors so they don't "disappear silently"
3 participants