Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop from 0.93.0 to 0.93.1 #8541

Merged
merged 1 commit into from
Oct 12, 2020

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps rubocop from 0.93.0 to 0.93.1.

Release notes

Sourced from rubocop's releases.

RuboCop 0.93.1

Bug fixes

  • #8782: Fix incorrect autocorrection for Style/TernaryParentheses with defined?. (@dvandersluis)
  • #8867: Rework Lint/RedundantSafeNavigation to be more safe. (@fatkodima)
  • #8864: Fix false positive for Style/RedundantBegin with a postfix while or until. (@dvandersluis)
  • #8869: Fix a false positive for Style/RedundantBegin when using begin for or assignment and method call. (@koic)
  • #8862: Fix an error for Lint/AmbiguousRegexpLiteral when using regexp without method calls in nested structure. (@koic)
  • #8872: Fix an error for Metrics/ClassLength when multiple assignments to constants. (@koic)
  • #8871: Fix a false positive for Style/RedundantBegin when using begin for method argument or part of conditions. (@koic)
  • #8875: Fix an incorrect auto-correct for Style/ClassEqualityComparison when comparing class name. (@koic)
  • #8880: Fix an error for Style/ClassLength when overlapping constant assignments. (@koic)
Changelog

Sourced from rubocop's changelog.

0.93.1 (2020-10-12)

Bug fixes

  • #8782: Fix incorrect autocorrection for Style/TernaryParentheses with defined?. ([@dvandersluis][])
  • #8867: Rework Lint/RedundantSafeNavigation to be more safe. ([@fatkodima][])
  • #8864: Fix false positive for Style/RedundantBegin with a postfix while or until. ([@dvandersluis][])
  • #8869: Fix a false positive for Style/RedundantBegin when using begin for or assignment and method call. ([@koic][])
  • #8862: Fix an error for Lint/AmbiguousRegexpLiteral when using regexp without method calls in nested structure. ([@koic][])
  • #8872: Fix an error for Metrics/ClassLength when multiple assignments to constants. ([@koic][])
  • #8871: Fix a false positive for Style/RedundantBegin when using begin for method argument or part of conditions. ([@koic][])
  • #8875: Fix an incorrect auto-correct for Style/ClassEqualityComparison when comparing class name. ([@koic][])
  • #8880: Fix an error for Style/ClassLength when overlapping constant assignments. ([@koic][])
Commits
  • f561472 Cut 0.93.1
  • c40307a Rework Lint/RedundantSafeNavigation to be more safe
  • eb9b664 [Fix #8880] Fix an error for Style/ClassLength
  • 0798771 Merge pull request #8876 from koic/fix_incorrect_autocorrect_for_class_equali...
  • ec93d26 Tweak the offense message for Style/ClassEqualityComparison
  • 4733d70 [Fix #8875] Fix incorrect autocorrect for Style/ClassEqualityComparison
  • 272771b [Fix #8871] Fix a false positive for Style/RedundantBegin
  • f488821 [Fix #8872] Fix an error for Metrics/ClassLength
  • f79e1c0 Merge pull request #8863 from koic/fix_error_for_ambiguous_regexp_literal
  • e36f120 [Fix #8862] Fix an error for Lint/AmbiguousRegexpLiteral
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file Ruby labels Oct 12, 2020
@gitpod-io
Copy link

gitpod-io bot commented Oct 12, 2020

@codeclimate
Copy link

codeclimate bot commented Oct 12, 2020

Code Climate has analyzed commit 95815ae and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #8541 into main will decrease coverage by 6.73%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8541      +/-   ##
==========================================
- Coverage   81.80%   75.07%   -6.74%     
==========================================
  Files         101      101              
  Lines        5896     6021     +125     
==========================================
- Hits         4823     4520     -303     
- Misses       1073     1501     +428     
Impacted Files Coverage Δ
app/channels/application_cable/channel.rb 0.00% <0.00%> (-100.00%) ⬇️
app/channels/application_cable/connection.rb 0.00% <0.00%> (-100.00%) ⬇️
app/channels/user_channel.rb 0.00% <0.00%> (-83.34%) ⬇️
app/channels/user_notification_channel.rb 0.00% <0.00%> (-83.34%) ⬇️
app/channels/room_channel.rb 0.00% <0.00%> (-71.43%) ⬇️
app/controllers/openid_controller.rb 0.00% <0.00%> (-53.90%) ⬇️
app/controllers/comment_controller.rb 72.82% <0.00%> (-14.14%) ⬇️
app/controllers/subscription_controller.rb 57.57% <0.00%> (-13.14%) ⬇️
app/controllers/users_controller.rb 68.40% <0.00%> (-12.64%) ⬇️
app/controllers/home_controller.rb 88.70% <0.00%> (-9.68%) ⬇️
... and 18 more

@dependabot-preview dependabot-preview bot merged commit 644998c into main Oct 12, 2020
@dependabot-preview dependabot-preview bot deleted the dependabot/bundler/rubocop-0.93.1 branch October 12, 2020 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Ruby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant