Added tags search to type-specific searches sidebar links #8532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
app/helpers/search_helper.rb
Outdated
| @@ -23,7 +23,8 @@ def create_nav_links_for_by_type(active_page, query) | |||
| { section: "search-all", text: "All content types", path: "/search/content/#{query}" }, | |||
| { section: "search-questions", text: "Questions", path: "/search/questions/#{query}" }, | |||
| { section: "search-notes", text: "Notes", path: "/search/notes/#{query}" }, | |||
| { section: "search-wikis", text: "Wikis", path: "/search/wikis/#{query}" } | |||
| { section: "search-wikis", text: "Wikis", path: "/search/wikis/#{query}" }, | |||
| { section: "search-tags", text: "Tags", path: "/search/tags/#{query}" } , | |||
app/helpers/search_helper.rb
Outdated
| @@ -23,7 +23,8 @@ def create_nav_links_for_by_type(active_page, query) | |||
| { section: "search-all", text: "All content types", path: "/search/content/#{query}" }, | |||
| { section: "search-questions", text: "Questions", path: "/search/questions/#{query}" }, | |||
| { section: "search-notes", text: "Notes", path: "/search/notes/#{query}" }, | |||
| { section: "search-wikis", text: "Wikis", path: "/search/wikis/#{query}" } | |||
| { section: "search-wikis", text: "Wikis", path: "/search/wikis/#{query}" }, | |||
| { section: "search-tags", text: "Tags", path: "/search/tags/#{query}" } , | |||
There was a problem hiding this comment.
Avoid comma after the last item of an array.
Codecov Report
@@ Coverage Diff @@
## main #8532 +/- ##
=======================================
Coverage 81.91% 81.91%
=======================================
Files 101 101
Lines 5896 5896
=======================================
Hits 4830 4830
Misses 1066 1066
|
Tlazypanda
approved these changes
Oct 11, 2020
|
Code Climate has analyzed commit 5122a9e and detected 0 issues on this pull request. View more on Code Climate. |
|
Fantastic!! Thanks so much!!! 🎉🎉🎉 |
piyushswain
pushed a commit
to piyushswain/plots2
that referenced
this pull request
Oct 22, 2020
…8532) * Added Home tooltip to Public Lab link in navbar * replaced .length and .count with .size * Added tags search to type-specific searches sidebar links * style typo fixed * Inserted a partial template to display topic cards on tags search results page
manchere
pushed a commit
to manchere/plots2
that referenced
this pull request
Feb 13, 2021
…8532) * Added Home tooltip to Public Lab link in navbar * replaced .length and .count with .size * Added tags search to type-specific searches sidebar links * style typo fixed * Inserted a partial template to display topic cards on tags search results page
lagunasmel
pushed a commit
to lagunasmel/plots2
that referenced
this pull request
Mar 2, 2021
…8532) * Added Home tooltip to Public Lab link in navbar * replaced .length and .count with .size * Added tags search to type-specific searches sidebar links * style typo fixed * Inserted a partial template to display topic cards on tags search results page
reginaalyssa
pushed a commit
to reginaalyssa/plots2
that referenced
this pull request
Oct 16, 2021
…8532) * Added Home tooltip to Public Lab link in navbar * replaced .length and .count with .size * Added tags search to type-specific searches sidebar links * style typo fixed * Inserted a partial template to display topic cards on tags search results page
ampwang
pushed a commit
to ampwang/plots2
that referenced
this pull request
Oct 26, 2021
…8532) * Added Home tooltip to Public Lab link in navbar * replaced .length and .count with .size * Added tags search to type-specific searches sidebar links * style typo fixed * Inserted a partial template to display topic cards on tags search results page
billymoroney1
pushed a commit
to billymoroney1/plots2
that referenced
this pull request
Dec 28, 2021
…8532) * Added Home tooltip to Public Lab link in navbar * replaced .length and .count with .size * Added tags search to type-specific searches sidebar links * style typo fixed * Inserted a partial template to display topic cards on tags search results page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8531 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
PR is descriptively titled 📑 and links the original issue above 🔗
tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with
rake testcode is in uniquely-named feature branch and has no merge conflicts 📁
screenshots/GIFs are attached 📎 in case of UI updation
ask
@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!