-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ruby version for rvm install in /doc/PREQUISITES.md #8502
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Code Climate has analyzed commit 8d615a9 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #8502 +/- ##
=======================================
Coverage 82.01% 82.01%
=======================================
Files 101 101
Lines 5894 5894
=======================================
Hits 4834 4834
Misses 1060 1060 |
It looks good to me @kofosu2289 👍🏾 |
This looks perfect, thanks so much - to both @kofosu2289 and to @RuthNjeri for creating and supporting this! Great job both of you -- merging this now, and congrats!!! |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
…#8502) Co-authored-by: Kenneth Ofosu <[email protected]>
…#8502) Co-authored-by: Kenneth Ofosu <[email protected]>
…#8502) Co-authored-by: Kenneth Ofosu <[email protected]>
…#8502) Co-authored-by: Kenneth Ofosu <[email protected]>
…#8502) Co-authored-by: Kenneth Ofosu <[email protected]>
…#8502) Co-authored-by: Kenneth Ofosu <[email protected]>
…#8502) Co-authored-by: Kenneth Ofosu <[email protected]>
Fixes #8497 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!