Replaced .count with .size in Line 49

[Annysah]

Fixes #8489 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[gitpod-io]

[codecov]

Codecov Report

Merging #8491 into main will decrease coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #8491      +/-   ##
==========================================
- Coverage   82.01%   81.79%   -0.23%     
==========================================
  Files         101      101              
  Lines        5894     5894              
==========================================
- Hits         4834     4821      -13     
- Misses       1060     1073      +13     

Impacted Files	Coverage Δ
app/models/answer.rb	73.68% <0.00%> (-26.32%)	⬇️
app/models/answer_selection.rb	31.25% <0.00%> (-6.25%)	⬇️
app/services/execute_search.rb	88.88% <0.00%> (-5.56%)	⬇️
app/api/srch/search.rb	66.87% <0.00%> (-3.83%)	⬇️

[cesswairimu]

Great job here 💯 almost there

[cesswairimu]

Seems like you added this m by mistake. Kindly edit the file and remove the m at the beginning of the file and commit.
you can find it here https://github.com/Annysah/plots2/blob/patch-6/app/views/search/all_content.html.erb.

[RuthNjeri]

Good job @Annysah, I'm just curious if changing .count to .size also applied to the queries too? Since multiple models use .count.. @cesswairimu can confirm this?

[RuthNjeri]

Also, there are some files that have been left out in the view like
Form Partial
Card Partial and line 29

and some more..

If you use Visual Studio Code as an editor, you can search the word count and you'll see all the files that reference it, that's what I have done @Annysah, if you are not using Visual Studio Code, I think you can just do a global search within those files, or use the global search of your editor.

[cesswairimu]

Yeah it applies to some of them, we have other issues opened for some of these files. sometimes .size does not replace .count seamlessly e.g on this line https://github.com/publiclab/plots2/blob/main/app/models/node.rb#L197 using .size returns nil but .count returns 0. That's why replacing a couple of files per issue is crucial so that we don't break existing functionality. Hope this answers your question Thanks

[RuthNjeri]

It's clear now, thanks @cesswairimu

[codeclimate]

Code Climate has analyzed commit 8571b01 and detected 0 issues on this pull request.

View more on Code Climate.

[Annysah]

Hello @cesswairimu thanks for the review, I have removed the m which was mistakenly added.
Can I get a review?

[Annysah]

Thanks @RuthNjeri

[Tlazypanda]

@Annysah Looking good 🎉 Thanks for working on this!!

[Annysah]

Thank you! @Tlazypanda

[cesswairimu]

Awesome all good now 🎉

[cesswairimu]

Thanks @Annysah for working on this 🚀 would you like to close the other pull requests since we updated all files here?
Thanks @Tlazypanda for the review 🎉

[welcome]

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

[cesswairimu]

NM, closed them. Thanks everyone

[Annysah]

Oh my!!! I'm so excited that my PR was merged!!!
Thank you so much! @cesswairimu