test 'incomplete spamaway test does not create new user record', and fix users controller to prevent user creation in this scenario #8467

jywarren · 2020-10-06T20:08:38Z

Re: #8463 and related to https://github.com/publiclab/plots2/blob/8c9c39da0152d5a965e7eb77697c056ca3d45111/test/system/signup_form_test.rb

gitpod-io · 2020-10-06T20:08:42Z

codecov · 2020-10-06T20:22:46Z

Codecov Report

Merging #8467 into main will decrease coverage by 26.94%.
The diff coverage is 16.66%.

@@             Coverage Diff             @@
##             main    #8467       +/-   ##
===========================================
- Coverage   80.06%   53.11%   -26.95%     
===========================================
  Files         101      101               
  Lines        5919     6226      +307     
===========================================
- Hits         4739     3307     -1432     
- Misses       1180     2919     +1739

Impacted Files	Coverage Δ
app/controllers/comment_controller.rb	`25.00% <0.00%> (-61.96%)`	⬇️
app/controllers/map_controller.rb	`10.52% <0.00%> (-39.48%)`	⬇️
app/controllers/search_controller.rb	`39.53% <0.00%> (-55.82%)`	⬇️
app/controllers/users_controller.rb	`51.67% <100.00%> (-28.33%)`	⬇️
app/models/drupal_content_field_mapper.rb	`0.00% <0.00%> (-100.00%)`	⬇️
app/models/drupal_content_field_map_editor.rb	`0.00% <0.00%> (-100.00%)`	⬇️
app/controllers/batch_controller.rb	`0.00% <0.00%> (-90.20%)`	⬇️
app/services/execute_search.rb	`0.00% <0.00%> (-88.89%)`	⬇️
app/controllers/user_tags_controller.rb	`0.00% <0.00%> (-84.29%)`	⬇️
app/controllers/features_controller.rb	`0.00% <0.00%> (-80.71%)`	⬇️
... and 36 more

jywarren · 2020-10-06T20:31:51Z

NIce! Hopefully failed for the right reason...

jywarren · 2020-10-06T20:32:38Z

Nice!

 FAIL["test_incomplete_spamaway_test_does_not_create_new_user_record,_returns_useful_validation", #<Minitest::Reporters::Suite:0x000000000e88ab68 @name="SignUpTest">, 223.629028694]
 test_incomplete_spamaway_test_does_not_create_new_user_record,_returns_useful_validation#SignUpTest (223.63s)
        "User.count" didn't change by 0.
        Expected: 19
          Actual: 20
        test/integration/signup_flow_test.rb:85:in `block in <class:SignUpTest>'

OK, now the fix...

jywarren · 2020-10-06T20:51:39Z

huh -- its not seeing: assert response.body.include? '1 error prohibited this user from being saved'

 FAIL["test_incomplete_spamaway_test_does_not_create_new_user_record,_returns_useful_validation", #<Minitest::Reporters::Suite:0x00000000147ae9f0 @name="SignUpTest">, 196.193361467]
 test_incomplete_spamaway_test_does_not_create_new_user_record,_returns_useful_validation#SignUpTest (196.19s)
        Expected false to be truthy.
        test/integration/signup_flow_test.rb:98:in `block in <class:SignUpTest>'

jywarren · 2020-10-06T20:52:58Z

trying in gitpod...

jywarren · 2020-10-06T21:01:12Z

Confirmed the message appears:

jywarren · 2020-10-06T21:07:55Z

aha, ok, i left the blank area filled, so we had 2 errors instead of 1... fixed!

jywarren · 2020-10-06T21:21:45Z

Hmm... now we get a failure on the next assertion:

 FAIL["test_incomplete_spamaway_test_does_not_create_new_user_record,_returns_useful_validation", #<Minitest::Reporters::Suite:0x000000000cafa760 @name="SignUpTest">, 21.407707958000003]
 test_incomplete_spamaway_test_does_not_create_new_user_record,_returns_useful_validation#SignUpTest (21.41s)
        Expected false to be truthy.
        test/integration/signup_flow_test.rb:99:in `block in <class:SignUpTest>'

jywarren · 2020-10-06T22:05:16Z

Same problem detecting text in test/integration/signup_flow_test.rb:99:in block in class:SignUpTest'` - testing manually in gitpod now...

jywarren · 2020-10-06T22:49:43Z

Oooh interesting... functional test failure, i'll try restarting it... -- a weird one!


/home/travis/.rvm/rubies/ruby-2.6.6/lib/ruby/2.6.0/uri/common.rb:739:in `URI': bad argument (expected URI object or URI string) (ArgumentError)
	from /home/travis/build/publiclab/plots2/vendor/.bundle/ruby/2.6.0/gems/codecov-0.2.11/lib/codecov.rb:406:in `upload_to_v4'
	from /home/travis/build/publiclab/plots2/vendor/.bundle/ruby/2.6.0/gems/codecov-0.2.11/lib/codecov.rb:372:in `upload_to_codecov'
	from /home/travis/build/publiclab/plots2/vendor/.bundle/ruby/2.6.0/gems/codecov-0.2.11/lib/codecov.rb:470:in `format'
	from /home/travis/build/publiclab/plots2/vendor/.bundle/ruby/2.6.0/gems/simplecov-0.19.0/lib/simplecov/result.rb:51:in `format!'
	from /home/travis/build/publiclab/plots2/vendor/.bundle/ruby/2.6.0/gems/simplecov-0.19.0/lib/simplecov/configuration.rb:196:in `block in at_exit'
	from /home/travis/build/publiclab/plots2/vendor/.bundle/ruby/2.6.0/gems/simplecov-0.19.0/lib/simplecov.rb:189:in `run_exit_tasks!'
	from /home/travis/build/publiclab/plots2/vendor/.bundle/ruby/2.6.0/gems/simplecov-0.19.0/lib/simplecov.rb:179:in `at_exit_behavior'
	from /home/travis/build/publiclab/plots2/vendor/.bundle/ruby/2.6.0/gems/simplecov-0.19.0/lib/minitest/simplecov_plugin.rb:11:in `block in plugin_simplecov_init'
	from /home/travis/build/publiclab/plots2/vendor/.bundle/ruby/2.6.0/gems/minitest-5.14.2/lib/minitest.rb:64:in `reverse_each'
	from /home/travis/build/publiclab/plots2/vendor/.bundle/ruby/2.6.0/gems/minitest-5.14.2/lib/minitest.rb:64:in `block (2 levels) in autorun'

jywarren · 2020-10-06T22:55:12Z

Nice!!! Merging.

cesswairimu · 2020-10-07T13:57:10Z

Fantastic 🎉

…fix users controller to prevent user creation in this scenario (publiclab#8467) * test 'incomplete spamaway test does not create new user record' * Update signup_flow_test.rb * Update users_controller.rb * Update users_controller.rb * make blank field actually blank? otherwise 2 errors * Update signup_flow_test.rb * Update signup_flow_test.rb * Update signup_flow_test.rb

test 'incomplete spamaway test does not create new user record'

cf434b4

jywarren mentioned this pull request Oct 6, 2020

Signup page captcha validation bug #8463

Closed

Update signup_flow_test.rb

35b4a68

Update users_controller.rb

d9955c6

jywarren requested a review from a team as a code owner October 6, 2020 20:32

jywarren changed the title ~~test 'incomplete spamaway test does not create new user record'~~ test 'incomplete spamaway test does not create new user record', and fix users controller to prevent user creation in this scenario Oct 6, 2020

Update users_controller.rb

fa5d032

make blank field actually blank? otherwise 2 errors

47b3bc7

jywarren added 2 commits October 6, 2020 17:23

Update signup_flow_test.rb

5ffeb0d

Update signup_flow_test.rb

041da4f

jywarren mentioned this pull request Oct 6, 2020

Sign up form validation test #8468

Merged

5 tasks

Update signup_flow_test.rb

9079455

jywarren merged commit 896b192 into main Oct 6, 2020

cesswairimu mentioned this pull request Oct 7, 2020

Spamaway check in signup is skipped #7775

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test 'incomplete spamaway test does not create new user record', and fix users controller to prevent user creation in this scenario #8467

test 'incomplete spamaway test does not create new user record', and fix users controller to prevent user creation in this scenario #8467

jywarren commented Oct 6, 2020

gitpod-io bot commented Oct 6, 2020 •

edited

Loading

codecov bot commented Oct 6, 2020 •

edited

Loading

jywarren commented Oct 6, 2020

jywarren commented Oct 6, 2020

jywarren commented Oct 6, 2020 •

edited

Loading

jywarren commented Oct 6, 2020

jywarren commented Oct 6, 2020

jywarren commented Oct 6, 2020

jywarren commented Oct 6, 2020

jywarren commented Oct 6, 2020

jywarren commented Oct 6, 2020

jywarren commented Oct 6, 2020

cesswairimu commented Oct 7, 2020

test 'incomplete spamaway test does not create new user record', and fix users controller to prevent user creation in this scenario #8467

test 'incomplete spamaway test does not create new user record', and fix users controller to prevent user creation in this scenario #8467

Conversation

jywarren commented Oct 6, 2020

gitpod-io bot commented Oct 6, 2020 • edited Loading

codecov bot commented Oct 6, 2020 • edited Loading

Codecov Report

jywarren commented Oct 6, 2020

jywarren commented Oct 6, 2020

jywarren commented Oct 6, 2020 • edited Loading

jywarren commented Oct 6, 2020

jywarren commented Oct 6, 2020

jywarren commented Oct 6, 2020

jywarren commented Oct 6, 2020

jywarren commented Oct 6, 2020

jywarren commented Oct 6, 2020

jywarren commented Oct 6, 2020

cesswairimu commented Oct 7, 2020

gitpod-io bot commented Oct 6, 2020 •

edited

Loading

codecov bot commented Oct 6, 2020 •

edited

Loading

jywarren commented Oct 6, 2020 •

edited

Loading