changed alert message on wiki creation

[Hassanelashram]

Fixes #4504

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[gitpod-io]

[Hassanelashram]

@gauravano Could you please review ?

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (main@39b51e8). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 465b351 differs from pull request most recent head 1f5a9e6. Consider uploading reports for the commit 1f5a9e6 to get more accurate results

@@           Coverage Diff           @@
##             main    #8452   +/-   ##
=======================================
  Coverage        ?   79.67%           
=======================================
  Files           ?       98           
  Lines           ?     5947           
  Branches        ?        0           
=======================================
  Hits            ?     4738           
  Misses          ?     1209           
  Partials        ?        0           

[grvsachdeva]

Hi @Hassanelashram, thank you for opening the PR. The current solution requires improvement. A new user can post to publiclab.org only if they have one approved node (question/research note).

Now, there can be 2 cases:

1. User has not created any note till now
2. User has created note(s) but it's still in review

Currently, we don't differentiate between the above 2 cases and show this message - Please post a question or other content before editing the wiki. Click here to learn why.

Now, either we can start differentiating with an extra condition to check if there is any post in review for the current user which will make one more DB query or we can just append in the current message to say that Please post a question or other content before editing the wiki. Click here to learn why. If you have already posted a note then you would be able to edit the wiki as soon as your post get approved by moderators -- something like this :)

@jywarren @cesswairimu what do you think would be better?

[cesswairimu]

I think differentiating the two and giving different flash messages would be ideal

[gitpod-io]

[jywarren]

Sorry, just trying to retrigger the tests now that we've resolved an unrelated issue!

[gitpod-io]

[gitpod-io]

[gitpod-io]

[cesswairimu]

I think this might need a rebase Travis still shows up after reopening

[gitpod-io]

[jywarren]

Rebased!

[jywarren]

So strange that this failed!? I don't understand -- we changed the test here too!

Progress: |=== FAIL WikiControllerTest#test_disallow_viewing_edit_wiki_page_for_first-timers (38.87s)
        --- expected
        +++ actual
        @@ -1 +1 @@
        -"Please post a question or other content before editing the wiki. Click <a href='https://publiclab.org/notes/tester/04-23-2016/new-moderation-system-for-first-time-posters'>here</a> to learn why."
        +"You can create the wiki once your research note/question is approved by moderators. Click <a href='https://publiclab.org/notes/tester/04-23-2016/new-moderation-system-for-first-time-posters'>here</a> to learn why."
        test/functional/wiki_controller_test.rb:196:in `block in <class:WikiControllerTest>'

[jywarren]

Aha! Ok, we actually have to make the change twice in the controller. I'll make a suggestion!!!

[jywarren]

OK, my apologies, there were a couple extra places to make the same change! I was able to add the extra changes and with luck this will now pass. Thank you for your patience!!

[codeclimate]

Code Climate has analyzed commit 1f5a9e6 and detected 0 issues on this pull request.

View more on Code Climate.

[jywarren]

Excellent, thank you so much!!!