Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation helper follow-up to #7881 #8450 #8451

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Translation helper follow-up to #7881 #8450 #8451

merged 1 commit into from
Oct 13, 2020

Conversation

jywarren
Copy link
Member

@jywarren jywarren commented Oct 2, 2020

Replacing #7881 #8450

@gitpod-io
Copy link

gitpod-io bot commented Oct 2, 2020

@jywarren jywarren mentioned this pull request Oct 2, 2020
Closed
@codecov
Copy link

codecov bot commented Oct 2, 2020 •
edited
Loading

Codecov Report

Merging #8451 into main will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8451   +/-   ##
=======================================
  Coverage   82.01%   82.01%           
=======================================
  Files         101      101           
  Lines        5899     5912   +13     
=======================================
+ Hits         4838     4849   +11     
- Misses       1061     1063    +2
Impacted Files Coverage Δ
app/models/node.rb 91.45% <ø> (-0.07%) ⬇️
app/controllers/comment_controller.rb 86.95% <100.00%> (ø)
app/controllers/map_controller.rb 50.00% <100.00%> (ø)
app/controllers/search_controller.rb 97.67% <100.00%> (ø)
app/controllers/users_controller.rb 81.04% <100.00%> (-0.08%) ⬇️
app/helpers/search_helper.rb 79.16% <0.00%> (-20.84%) ⬇️
app/models/spamaway.rb 97.43% <0.00%> (+2.56%) ⬆️
app/mailers/subscription_mailer.rb 98.43% <0.00%> (+4.31%) ⬆️

@jywarren jywarren closed this Oct 7, 2020
@jywarren jywarren reopened this Oct 7, 2020
@gitpod-io
Copy link

gitpod-io bot commented Oct 7, 2020

@cesswairimu cesswairimu mentioned this pull request Oct 8, 2020
Closed
5 tasks
@jywarren jywarren merged commit 86776c2 into main Oct 13, 2020
@jywarren
Copy link
Member Author

Let's test this in stable, though...

jywarren added a commit that referenced this pull request Oct 13, 2020
@jywarren
Revert "Translation helper follow-up to #7881 #8450 (#8451)"
fc01929 
This reverts commit 86776c2.
@jywarren jywarren mentioned this pull request Oct 13, 2020
Merged
jywarren added a commit that referenced this pull request Oct 13, 2020
@jywarren
Revert "Translation helper follow-up to #7881 #8450 (#8451)" (#8565)
0c199c6 
This reverts commit 86776c2.
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
@jywarren
Translation helper follow-up to publiclab#7881 publiclab#8450 (public…
f45f47e 
…lab#8451)

Replacing publiclab#7881 publiclab#8450
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
@jywarren
Revert "Translation helper follow-up to publiclab#7881 publiclab#8450 (…
c305b23 
…publiclab#8451)" (publiclab#8565)

This reverts commit 86776c2.
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
@jywarren @manchere
Translation helper follow-up to publiclab#7881 publiclab#8450 (public…
067ebf1 
…lab#8451)

Replacing publiclab#7881 publiclab#8450
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
@jywarren @manchere
Revert "Translation helper follow-up to publiclab#7881 publiclab#8450 (…
cab0896 
…publiclab#8451)" (publiclab#8565)

This reverts commit 86776c2.
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
@jywarren @lagunasmel
Translation helper follow-up to publiclab#7881 publiclab#8450 (public…
78d7e4f 
…lab#8451)

Replacing publiclab#7881 publiclab#8450
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
@jywarren @lagunasmel
Revert "Translation helper follow-up to publiclab#7881 publiclab#8450 (…
d7f9eed 
…publiclab#8451)" (publiclab#8565)

This reverts commit 86776c2.
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
@jywarren @reginaalyssa
Translation helper follow-up to publiclab#7881 publiclab#8450 (public…
175e82d 
…lab#8451)

Replacing publiclab#7881 publiclab#8450
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
@jywarren @reginaalyssa
Revert "Translation helper follow-up to publiclab#7881 publiclab#8450 (…
60c5709 
…publiclab#8451)" (publiclab#8565)

This reverts commit 86776c2.
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
@jywarren
Translation helper follow-up to publiclab#7881 publiclab#8450 (public…
339eae7 
…lab#8451)

Replacing publiclab#7881 publiclab#8450
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
@jywarren
Revert "Translation helper follow-up to publiclab#7881 publiclab#8450 (…
f9ace57 
…publiclab#8451)" (publiclab#8565)

This reverts commit 86776c2.
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
@jywarren @billymoroney1
Translation helper follow-up to publiclab#7881 publiclab#8450 (public…
62df04f 
…lab#8451)

Replacing publiclab#7881 publiclab#8450
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
@jywarren @billymoroney1
Revert "Translation helper follow-up to publiclab#7881 publiclab#8450 (…
14d6364 
…publiclab#8451)" (publiclab#8565)

This reverts commit 86776c2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jywarren