-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pagy for blogs #8446
Add pagy for blogs #8446
Conversation
@publiclab/reviewers I think it should be good to go! 😄 (does that @ work? lol) |
Codecov Report
@@ Coverage Diff @@
## main #8446 +/- ##
=======================================
Coverage 81.87% 81.87%
=======================================
Files 101 101
Lines 5899 5899
=======================================
Hits 4830 4830
Misses 1069 1069
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tyler-wel That was blazing fast 🔥 Welcome to Public Lab 🎈
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Looks awesome! Great work and many thanks!!!! 🔥🔥🔥 |
Fixes #8443
Adds pagy pagination for the blogs route. As stated in the issue, the
/blog
endpoint directs to thetags#blog
action 👍rake test
@publiclab/reviewers
for help, in a comment belowBefore
After
If tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!