Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework order_by for tag page wiki pagination #8422

Merged
merged 3 commits into from
Sep 22, 2020
Merged

Conversation

jywarren
Copy link
Member

Fixes #7334

@gitpod-io
Copy link

gitpod-io bot commented Sep 22, 2020

@codecov
Copy link

codecov bot commented Sep 22, 2020

Codecov Report

Merging #8422 into main will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8422      +/-   ##
==========================================
+ Coverage   81.89%   82.01%   +0.11%     
==========================================
  Files         101      101              
  Lines        5900     5899       -1     
==========================================
+ Hits         4832     4838       +6     
+ Misses       1068     1061       -7     
Impacted Files Coverage Δ
app/controllers/tag_controller.rb 81.40% <100.00%> (-0.06%) ⬇️
app/api/srch/search.rb 70.06% <0.00%> (+3.82%) ⬆️
app/services/execute_search.rb 94.44% <0.00%> (+5.55%) ⬆️

@jywarren jywarren merged commit 2e01a92 into main Sep 22, 2020
shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020
* rework order_by for publiclab#7334

* adjust sort dropdown text

* rubocop/codeclimate formatting
alvesitalo pushed a commit to alvesitalo/plots2 that referenced this pull request Oct 14, 2020
* rework order_by for publiclab#7334

* adjust sort dropdown text

* rubocop/codeclimate formatting
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
* rework order_by for publiclab#7334

* adjust sort dropdown text

* rubocop/codeclimate formatting
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
* rework order_by for publiclab#7334

* adjust sort dropdown text

* rubocop/codeclimate formatting
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
* rework order_by for publiclab#7334

* adjust sort dropdown text

* rubocop/codeclimate formatting
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
* rework order_by for publiclab#7334

* adjust sort dropdown text

* rubocop/codeclimate formatting
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
* rework order_by for publiclab#7334

* adjust sort dropdown text

* rubocop/codeclimate formatting
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
* rework order_by for publiclab#7334

* adjust sort dropdown text

* rubocop/codeclimate formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong wiki count in Dropdown by type
1 participant