Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notify on approved-first-post #8421

Merged
merged 2 commits into from
Sep 22, 2020
Merged

notify on approved-first-post #8421

merged 2 commits into from
Sep 22, 2020

Conversation

jywarren
Copy link
Member

@jywarren jywarren commented Sep 22, 2020

Fixes #3845 Fixes #5914

😄

Notification should still happen upon publication:

SubscriptionMailer.notify_node_creation(@node).deliver_now

@gitpod-io
Copy link

gitpod-io bot commented Sep 22, 2020

@codecov
Copy link

codecov bot commented Sep 22, 2020

Codecov Report

Merging #8421 into main will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8421      +/-   ##
==========================================
- Coverage   81.89%   81.88%   -0.02%     
==========================================
  Files         101      101              
  Lines        5900     5900              
==========================================
- Hits         4832     4831       -1     
- Misses       1068     1069       +1     
Impacted Files Coverage Δ
app/models/node.rb 91.51% <100.00%> (-0.18%) ⬇️

@jywarren
Copy link
Member Author

aha - this test:


 FAIL["test_should_redirect_to_questions_show_page_after_creating_a_new_question", #<Minitest::Reporters::Suite:0x0000000011bc04b0 @name="NotesControllerTest">, 67.653563125]
 test_should_redirect_to_questions_show_page_after_creating_a_new_question#NotesControllerTest (67.65s)
        1 emails expected, but 0 were sent.
        Expected: 1
          Actual: 0
        test/functional/notes_controller_test.rb:523:in `block (2 levels) in <class:NotesControllerTest>'
        test/functional/notes_controller_test.rb:522:in `block in <class:NotesControllerTest>'

@jywarren jywarren merged commit e3d8aaf into main Sep 22, 2020
shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020
* notify on approved-first-post

* Update notes_controller_test.rb
alvesitalo pushed a commit to alvesitalo/plots2 that referenced this pull request Oct 14, 2020
* notify on approved-first-post

* Update notes_controller_test.rb
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
* notify on approved-first-post

* Update notes_controller_test.rb
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
* notify on approved-first-post

* Update notes_controller_test.rb
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
* notify on approved-first-post

* Update notes_controller_test.rb
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
* notify on approved-first-post

* Update notes_controller_test.rb
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
* notify on approved-first-post

* Update notes_controller_test.rb
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
* notify on approved-first-post

* Update notes_controller_test.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant