-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
notify on approved-first-post #8421
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #8421 +/- ##
==========================================
- Coverage 81.89% 81.88% -0.02%
==========================================
Files 101 101
Lines 5900 5900
==========================================
- Hits 4832 4831 -1
- Misses 1068 1069 +1
|
aha - this test:
|
shubhangikori
pushed a commit
to shubhangikori/plots2
that referenced
this pull request
Oct 12, 2020
* notify on approved-first-post * Update notes_controller_test.rb
alvesitalo
pushed a commit
to alvesitalo/plots2
that referenced
this pull request
Oct 14, 2020
* notify on approved-first-post * Update notes_controller_test.rb
piyushswain
pushed a commit
to piyushswain/plots2
that referenced
this pull request
Oct 22, 2020
* notify on approved-first-post * Update notes_controller_test.rb
manchere
pushed a commit
to manchere/plots2
that referenced
this pull request
Feb 13, 2021
* notify on approved-first-post * Update notes_controller_test.rb
lagunasmel
pushed a commit
to lagunasmel/plots2
that referenced
this pull request
Mar 2, 2021
* notify on approved-first-post * Update notes_controller_test.rb
reginaalyssa
pushed a commit
to reginaalyssa/plots2
that referenced
this pull request
Oct 16, 2021
* notify on approved-first-post * Update notes_controller_test.rb
ampwang
pushed a commit
to ampwang/plots2
that referenced
this pull request
Oct 26, 2021
* notify on approved-first-post * Update notes_controller_test.rb
billymoroney1
pushed a commit
to billymoroney1/plots2
that referenced
this pull request
Dec 28, 2021
* notify on approved-first-post * Update notes_controller_test.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3845 Fixes #5914
😄
Notification should still happen upon publication:
plots2/app/controllers/admin_controller.rb
Line 208 in be2d6c2