Edit unique title validation failure message #8416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## main #8416 +/- ##
=======================================
Coverage 81.89% 81.89%
=======================================
Files 101 101
Lines 5900 5900
=======================================
Hits 4832 4832
Misses 1068 1068 |
|
@sagarpreet-chadha , could you review this? |
|
@jywarren , is this good? Also check this out #8225 (comment) . |
cesswairimu
approved these changes
Sep 25, 2020
|
Ohhhhh this is super. Thanks so much!! |
shubhangikori
pushed a commit
to shubhangikori/plots2
that referenced
this pull request
Oct 12, 2020
* Add .deepsource.toml * Delete .deepsource.toml * edit failure message Co-authored-by: DeepSource Bot <[email protected]>
alvesitalo
pushed a commit
to alvesitalo/plots2
that referenced
this pull request
Oct 14, 2020
* Add .deepsource.toml * Delete .deepsource.toml * edit failure message Co-authored-by: DeepSource Bot <[email protected]>
piyushswain
pushed a commit
to piyushswain/plots2
that referenced
this pull request
Oct 22, 2020
* Add .deepsource.toml * Delete .deepsource.toml * edit failure message Co-authored-by: DeepSource Bot <[email protected]>
manchere
pushed a commit
to manchere/plots2
that referenced
this pull request
Feb 13, 2021
* Add .deepsource.toml * Delete .deepsource.toml * edit failure message Co-authored-by: DeepSource Bot <[email protected]>
lagunasmel
pushed a commit
to lagunasmel/plots2
that referenced
this pull request
Mar 2, 2021
* Add .deepsource.toml * Delete .deepsource.toml * edit failure message Co-authored-by: DeepSource Bot <[email protected]>
reginaalyssa
pushed a commit
to reginaalyssa/plots2
that referenced
this pull request
Oct 16, 2021
* Add .deepsource.toml * Delete .deepsource.toml * edit failure message Co-authored-by: DeepSource Bot <[email protected]>
ampwang
pushed a commit
to ampwang/plots2
that referenced
this pull request
Oct 26, 2021
* Add .deepsource.toml * Delete .deepsource.toml * edit failure message Co-authored-by: DeepSource Bot <[email protected]>
billymoroney1
pushed a commit
to billymoroney1/plots2
that referenced
this pull request
Dec 28, 2021
* Add .deepsource.toml * Delete .deepsource.toml * edit failure message Co-authored-by: DeepSource Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8319
After this fix:
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!