-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update both instances from length to size #8412
Conversation
@Tlazypanda I made the changes here, could you please assign yourself as a reviewer as i can't? also, I did not change the first instance of .length to .size as it was in a JS script tag and was not sure. |
Codecov Report
@@ Coverage Diff @@
## main #8412 +/- ##
=======================================
Coverage 81.89% 81.89%
=======================================
Files 101 101
Lines 5900 5900
=======================================
Hits 4832 4832
Misses 1068 1068 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Hassanelashram LGTM 🎉
@Tlazypanda Awesome, so that's it right ? You guys will take care of the merging ? |
Yeah @Hassanelashram the maintainers will merge it when they are available next 😅 In the meantime feel free to dig deeper into the codebase or find other issues to work on ✌️ Welcome to Public Lab 🎈 |
Hi @Hassanelashram, we encourage contributors to take one first-timer-only issue( These are issues with that label) and leave the others for new contributors coming in. Since this PR is ready, I would suggest we merge this PR and close #8402 to give another new contributor a chance to work on that. How does this sound? Thanks |
Merging this and closing the other one. Thanks all |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Thanks @Hassanelashram @Tlazypanda @cesswairimu !!! 🎉 |
@jywarren Pleasure! Hope I can be more helpful ehe 🤗 |
Fixes #8408
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!