Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update both instances from length to size #8412

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

Hassanelashram
Copy link
Member

Fixes #8408

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@gitpod-io
Copy link

gitpod-io bot commented Sep 19, 2020

@Hassanelashram
Copy link
Member Author

@Tlazypanda I made the changes here, could you please assign yourself as a reviewer as i can't?

also, I did not change the first instance of .length to .size as it was in a JS script tag and was not sure.

@codecov
Copy link

codecov bot commented Sep 19, 2020

Codecov Report

Merging #8412 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8412   +/-   ##
=======================================
  Coverage   81.89%   81.89%           
=======================================
  Files         101      101           
  Lines        5900     5900           
=======================================
  Hits         4832     4832           
  Misses       1068     1068           

Copy link
Collaborator

@Tlazypanda Tlazypanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Hassanelashram LGTM 🎉

@Hassanelashram
Copy link
Member Author

@Tlazypanda Awesome, so that's it right ? You guys will take care of the merging ?

@Tlazypanda
Copy link
Collaborator

Yeah @Hassanelashram the maintainers will merge it when they are available next 😅 In the meantime feel free to dig deeper into the codebase or find other issues to work on ✌️ Welcome to Public Lab 🎈

@cesswairimu
Copy link
Collaborator

Hi @Hassanelashram, we encourage contributors to take one first-timer-only issue( These are issues with that label) and leave the others for new contributors coming in. Since this PR is ready, I would suggest we merge this PR and close #8402 to give another new contributor a chance to work on that. How does this sound? Thanks

@cesswairimu
Copy link
Collaborator

Merging this and closing the other one. Thanks all

@cesswairimu cesswairimu merged commit 24ab9cf into publiclab:main Sep 28, 2020
@welcome
Copy link

welcome bot commented Sep 28, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@jywarren
Copy link
Member

Thanks @Hassanelashram @Tlazypanda @cesswairimu !!! 🎉

@Hassanelashram
Copy link
Member Author

Thanks @Hassanelashram @Tlazypanda @cesswairimu !!! 🎉

@jywarren Pleasure! Hope I can be more helpful ehe 🤗

shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020
alvesitalo pushed a commit to alvesitalo/plots2 that referenced this pull request Oct 14, 2020
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace .length with .size for questions/show.html.erb
4 participants